Conversation
…d review The review profile rake task is used to pass or reject users after fraud review. We have a test case for users who running that task against a user who is not pending fraud review because they have undergone a more recent verification. Previously that test case actually tested a case where a user had an invalid profile state that was pending GPO verification. This should not be possible and raises an exception. It also did not match the spec description. This commit cleans up the spec to cover the case described in the spec description. In this case the user has reset their password and deactivated the fraud pending profile. Then they have created a new profile that is GPO pending. A new spec is also introduced to cover the code paths covered by the old test: a case where the profile is in an unexpected state and an exception is raised. [skip changelog]
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review profile rake task is used to pass or reject users after fraud review. We have a test case for users who running that task against a user who is not pending fraud review because they have undergone a more recent verification. Previously that test case actually tested a case where a user had an invalid profile state that was pending GPO verification. This should not be possible and raises an exception. It also did not match the spec description.
This commit cleans up the spec to cover the case described in the spec description. In this case the user has reset their password and deactivated the fraud pending profile. Then they have created a new profile that is GPO pending.
A new spec is also introduced to cover the code paths covered by the old test: a case where the profile is in an unexpected state and an exception is raised.
[skip changelog]