LG-10886 remove ssn from flow session#9182
Merged
soniaconnolly merged 11 commits intomainfrom Sep 12, 2023
Merged
Conversation
…sion Changelog: Internal, Identity Verification, move ssn to idv_session, part 2 of 2
…ore action Co-authored-by: Gina Yamada <gina.yamada@gsa.gov>
Co-authored-by: Gina Yamada <gina.yamada@gsa.gov>
…-ssn-from-flow-session
…-ssn-from-flow-session
matthinz
approved these changes
Sep 11, 2023
6 tasks
svalexander
reviewed
Sep 12, 2023
|
|
||
| def confirm_ssn_step_complete | ||
| return if pii.present? && (idv_session.ssn.present? || pii[:ssn].present?) | ||
| return if pii.present? && idv_session.ssn.present? |
Contributor
There was a problem hiding this comment.
Just wondering if we still need to check pii.present? as it seems we were checking it since we were grind ssn from pii.
Contributor
Author
There was a problem hiding this comment.
Good question. We're calling this from the verify_info controllers, and they require pii to be present so I decided to leave the check here. We could consider making a separate before action in the future that confirms that pii is present. Or rename this method.
Contributor
There was a problem hiding this comment.
Ahh ok i see, makes sense. I like the idea of a before action.
…-ssn-from-flow-session
soniaconnolly
deleted the
sonia-lg-10886-remove-ssn-from-flow-session
branch
Merged
aduth
added a commit
that referenced
this pull request
Sep 14, 2023
2 tasks
Merged
soniaconnolly
added a commit
that referenced
this pull request
Sep 18, 2023
soniaconnolly
added a commit
that referenced
this pull request
Sep 18, 2023
* Revert "Revert "LG-10886 remove ssn from flow session (#9182)" (#9209)" Fixed 50/50 state issue by adding :ssn to pii going to proof resolution job in deploy 314.2. This reverts commit 4f0ad04. * Don't use ||= when adding ssn to pii for proof resolution job If someone updates their SSN, we want it to be updated for the proofing job, so use =
mitchellhenke
pushed a commit
that referenced
this pull request
Sep 18, 2023
* Revert "Revert "LG-10886 remove ssn from flow session (#9182)" (#9209)" Fixed 50/50 state issue by adding :ssn to pii going to proof resolution job in deploy 314.2. This reverts commit 4f0ad04. * Don't use ||= when adding ssn to pii for proof resolution job If someone updates their SSN, we want it to be updated for the proofing job, so use =
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10886
🛠 Summary of changes
After #9129 and #9168 are deployed, finish removing ssn from flow_session[:pii_from_doc] and flow_session[:pii_from_user]
📜 Testing Plan