Merged
Conversation
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
We changed the naming to explicitly state that this is a sp session
changelog: Internal, Session Rename, rename decorated session and its children to service provider names
Comment on lines
9
to
-11
| def call | ||
| if sp | ||
| ServiceProviderSessionDecorator.new( |
Contributor
There was a problem hiding this comment.
as long as we're here, could we consider renaming this from #call to #create or maybe even #session? Makes it clearer what the result is IMO
Contributor
There was a problem hiding this comment.
That bugged me too. I went for create_session since we have so many uses of session already.
…ntity-idp into abrad-lg-11000-session-presenter
jmhooper
approved these changes
Sep 18, 2023
soniaconnolly
approved these changes
Sep 18, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM. Maybe someday we can find a way around all the mocking that's happening in the view specs around decorated_sp_session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11000
🛠 Summary of changes
We looked at DecoratedSession and its two children classes SessionDecorator and ServiceProviderSessionDecorator and renamed them for clarity.
decorated_sessioninApplicationControlleris nowdecorated_sp_sessionto emphasize that we are dealing with service provider sessions.The
DecoratedSessionclass is renamed toServiceProviderSessionCreatorsince it is the parent class to creating decorated service provider sessions.SessionDecoratoris renamed toNullServiceProviderSessionto show that it is an empty session without a service providerServiceProviderSessionDecoratoris renamed toServiceProviderSession