Conversation
…tiate between act creation and deletion
…nction between account creation and management in mfa
aduth
reviewed
Sep 5, 2023
app/controllers/two_factor_authentication/otp_verification_controller.rb
Outdated
Show resolved
Hide resolved
aduth
reviewed
Sep 11, 2023
| if backup_code_confirmation_needed? | ||
| confirm_backup_codes_path | ||
| else | ||
| user_session.delete(:in_account_creation_flow) |
Contributor
There was a problem hiding this comment.
Is this redundant here if after_skip_path is called from the skip method, and we're already deleting there?
app/controllers/two_factor_authentication/otp_verification_controller.rb
Outdated
Show resolved
Hide resolved
…e-sign-up-and-creation
…e-sign-up-and-creation
aduth
approved these changes
Sep 15, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Pre-approving with some mostly-minor comments. 👍 I think the primary one to consider is the one about the in_multi_mfa_selection_flow? helper method.
app/controllers/two_factor_authentication/otp_verification_controller.rb
Show resolved
Hide resolved
aduth
reviewed
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10769: Better differentiate between account creation and deletion
🛠 Summary of changes
This will change the logging so its more sueful to figure out when the user is going through account creation vs deletion.
More Detailed definition as we are moving from leveraging the MFA setup screen in not just account creation but also account deletion.