LG-10657 Add idv_session.pii_from_doc to replace flow_session[:pii_from_doc]#9195
Merged
soniaconnolly merged 8 commits intomainfrom Sep 20, 2023
Merged
Conversation
Now that we are not using the Flow State Machine, we can stop using flow_session. This is the last attribute to move out in the remote flow. changelog: Internal, Identity Verification, start moving pii_from_doc to idv_session
…moving-pii-from-doc-to-idv-session
6 tasks
…moving-pii-from-doc-to-idv-session
matthinz
approved these changes
Sep 13, 2023
Contributor
matthinz
left a comment
matthinz
left a comment
There was a problem hiding this comment.
👍 LGTM, tested and it works
…moving-pii-from-doc-to-idv-session
jmhooper
approved these changes
Sep 18, 2023
…moving-pii-from-doc-to-idv-session
…moving-pii-from-doc-to-idv-session
…moving-pii-from-doc-to-idv-session
soniaconnolly
deleted the
sonia-lg-10657-start-moving-pii-from-doc-to-idv-session
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10657
🛠 Summary of changes
Merge this after #9182 (remove ssn from flow_session) is deployed.
Now that we are not using the Flow State Machine, we can stop using flow_session. This is the last attribute to move out in the remote flow.
Add pii_from_doc to idv_session as step 1 of moving it out of flow_session. Make sure both are written everywhere a change is made. (Except right before calling the proofing job in VerifyInfoConcern, since the one that's written is the one that's passed in to the job on the same instance.)
A followup PR will delete instances of flow_session[:pii_from_doc], and also remove references to flow_session where possible.
Note that VerifyInfoConcern is also used by the InPerson::VerifyInfoController, which uses pii_from_user, not pii_from_doc, and still has steps in the Flow State Machine which don't have access to idv_session. (Maybe we could give the two remaining FSM steps access to idv_session?)
📜 Testing Plan