Merged
Conversation
* changelog: Internal, In-Person Proofing, Change Address Search i18n lib * Update tests and include long-form address search
* Bump @18f/identity-design-system from 7.0.1 to 7.1.0 Bumps [@18f/identity-design-system](https://github.com/18F/identity-design-system) from 7.0.1 to 7.1.0. - [Release notes](https://github.com/18F/identity-design-system/releases) - [Changelog](https://github.com/18F/identity-design-system/blob/main/CHANGELOG.md) - [Commits](18F/identity-design-system@v7.0.1...v7.1.0) --- updated-dependencies: - dependency-name: "@18f/identity-design-system" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Remove upstream'd fix patches --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* Use 'profile.updated_at` not `in_person_enrollment.updated_at` Some profiles for in-person enrollment don't have an an in_person_enrollment associated with them, so use the profile's timestamp instead. If `updated_at` is nil, fall back to `created_at` changelog: Internal,In-person proofing,backfill `in_person_pending_at` column Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
changelog: User-facing Improvements, IdV, added state ID number to 'verify your info' screen
…rs (#9089) A previous commit added a job to create an identity verification report based on cloudwatch data. The job creates the report and uploads it to S3. Since this is the first report to leverage cloudwatch data in this way we planned on manually testing the report before setting it up to run on a recurring basis. This commit does the rest of the work to make the report run regularly after we confirm it actually works. [skip changelog]
This require being gone was causing errors when running query-cloudwatch locally. [skip changelog]
* Hardcoding name of container main tag * Bug Fixes, Gitlab CI, Hardcode container tag instead of using protected variable * changelog: Bug Fixes, Gitlab CI, Hardcode container tag instead of using protected variable
* Remove unused AlertComponent in link sent [skip changelog] * Remove unused alert component from agreement step and spec Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com> * Remove flow_session from agreement show view spec Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com> * Remove unused alert component in getting started and specs Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com> * Remove reference to error messages partial using flow_session in hybrid handoff Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com> * Remove unused flow_session and elements in link sent Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com> * Delete _error_messages.html.erb Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com> --------- Co-authored-by: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
…KMS key (#9114) We are working on migrating between KMS keys. The new key will support multi-region encryption. As part of this migration we encrypting records with both keys. Previous commits added code for encrypting with both keys and writing ciphertexts for both on `INSERT` and `UPDATE`. This commit adds tooling for going back and updating records that are not being changed by normal user behavior. changelog: Internal, Multi-Region KMS, A multi-region KMS pii migrator was added for future use to encrypt and save encrypted pii and encrypted recovery pii columns with the new multi-region KMS key after decrypting the KMS layer with the single region KMS key.
* Initial implementation and tests Not working yet * Fix bug; get tests passing * Simplify tests * Simplify tests more * Rename feature flag * changelog: Internal, IPP enrollment updates by email, Add configurable email address for status updates * Remove hard-coded default config value
…9102) * add failing spec * Fix 500 with blank token when attempting to update service providers changelog: Bug Fixes, Dashboard Integration, Fix 500 with blank token when attempting to update service providers
Improved query for GPO reminder letters. Specifically: - A user who is in the in-person flow can also request a GPO letter. They should get reminders. - Users whose requests for GPO letters have expired should not get reminders. co-authored by: Jonathan Hooper <jonathan.hooper@gsa.gov> Changelog: Bug Fixes,Verify by Mail,Fixed database query for reminder letters
…ith multi-region KMS keys (#9116) We are working on migrating from a single-region KMS key to a multi-region KMS key. Previous commits configured the application to encrypt with both the single-region and multi-region key. Data that is not be actively accessed by the application will need to be backfilled. A previous commit (6ef490e) added the `ProfileMigrator` to handle this for the `profiles` table. This commit adds a background job to query for profiles that need to be migrated. The background job then invokes `ProfileMigrator#migrate!` for those profiles. There is concern about a race condition involving a profile being updated by the job at the same time it is being modified by a user. To handle this the `profile` record is locked while this update is taking place. changelog: Internal, Multi-Region KMS, A MultiRegionKmsMigration::ProfileMigrationJob job was added to query for profiles that are not encrypted with a multi-region KMS key and invoke the MultiRegionKmsMigration::ProfileMigrator added previously to migrate the profiles from being encrypted with a single-region KMS key only to being encrypted with both a single-region KMS key and a multi-region KMS key in order to support the larger migration from a single-region KMS key to a multi-region KMS key. Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
* Read via pii_from_doc method in document_capture_controller * Read via pii_from_doc method in link_sent_controller * Standardize on :pii_from_doc as flow_session key, not 'pii_from_doc' * Read via pii_from_doc method in verify_info_controller [skip changelog]
changelog: Internal, Code Quality, Remove unused code
* add user#establishing_in_person_enrollment_with_address used this method to check for in_person_enrollments. the user has an establishing enrollment with an address selected which means they are ready for the next steps for in person proofing * use user#establishing_in_person_enrollment_with_address? * changing ipp method for step indicator concern * remove proofing component methods from step_indicator_concern * use in_person selected location details to determine if ipp ready * changed name to user#has_in_person_enrollment? * add changelog changelog: Internal, IdV IPP, consolidate in_person_enrollment? methods * remove profile#pending_in_person_enrollment? * use new has_in_person_enrollment? * fix error in idv step concern * fix idv_step_concern spec * only check for establishing or pending ipp statuses * linty mclinterson * check profile in person enrollment on gpo verify * add #has_pending_in_person_enrollment * make current_user#has_in_person_enrollment more explicit in idv session * fix method missing * Remove unused private method * Replace private method with inline boolean computation * Use `User#has_in_person_enrollment?` in `GpoVerifyForm#submit` * Format establishing in person enrollment in gpo form spec * Name test object better * Test pending in person enrollment * Call `User.has_establishing_in_person_enrollment_safe?` from `GpoVerifyForm#submit` There is a possibility that `User` has inconsistent enrollment data, so we trust the enrollment associated with its `pending_profile` object instead for safety. We capture this scenario in a new user spec. This can be re-implemented once enrollment data is consistent. * Correctly describe spec * Remove unnecessary expectation in user spec * Remove unnecessary expectation in user spec * We will always trust `pending_profile` for this value --------- Co-authored-by: Kimball Bighorse <kbighorse@yahoo.com>
changelog: User-Facing Improvements, In-person Proofing, Pass enrollments with supported secondary ID types
zachmargolis
approved these changes
Aug 31, 2023
mitchellhenke
approved these changes
Aug 31, 2023
* add failing spec * Call correct method to delete symlink changelog: Bug Fixes, Service Provider Setup, Call correct method to delete symlink
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
in_person_pending_atcolumn (#9097)