Skip to content

LG-9559 Add document ID number to verify info screen#9090

Merged
jmax-gsa merged 1 commit intomainfrom
jmax/LG-9559-add-document-number-to-verify-your-info-screen
Aug 29, 2023
Merged

LG-9559 Add document ID number to verify info screen#9090
jmax-gsa merged 1 commit intomainfrom
jmax/LG-9559-add-document-number-to-verify-your-info-screen

Conversation

@jmax-gsa
Copy link
Contributor

@jmax-gsa jmax-gsa commented Aug 25, 2023

🎫 Ticket

LG-9559

🛠 Summary of changes

Added document ID number to the 'verify your info' screen.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Create a new user and enter identity verification
  • Proceed through the remote IdV flow to the 'verify your information' screen
  • Verify that the document ID number is displayed as shown in the Figma
  • Verify that the Address 2 lable is present, as shown in the Figma

The updated app may be reached at test-app

👀 Screenshots

Before:

Screenshot 2023-08-25 at 12 03 30 PM

After:

Screenshot 2023-08-25 at 12 02 43 PM

@jmax-gsa jmax-gsa force-pushed the jmax/LG-9559-add-document-number-to-verify-your-info-screen branch from 8280b38 to 2677158 Compare August 25, 2023 16:14
@jmax-gsa jmax-gsa requested review from a team and Kamal-Munshi August 25, 2023 16:25
@jmax-gsa jmax-gsa marked this pull request as ready for review August 25, 2023 16:27
Copy link
Contributor

@soniaconnolly soniaconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tried it, works as described.

(I edited your comment to add a line with two spaces before each image to make the images show up.)

changelog: User-facing Improvements, IdV, added state ID number to 'verify your info' screen
@jmax-gsa jmax-gsa force-pushed the jmax/LG-9559-add-document-number-to-verify-your-info-screen branch from 2677158 to bc0ae7d Compare August 28, 2023 16:10
@jmax-gsa jmax-gsa merged commit 9883d83 into main Aug 29, 2023
@jmax-gsa jmax-gsa deleted the jmax/LG-9559-add-document-number-to-verify-your-info-screen branch August 29, 2023 14:46
@aduth
Copy link
Contributor

aduth commented Aug 29, 2023

Should we have some test coverage for this?

@mdiarra3 mdiarra3 mentioned this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants