Use correct method to delete symlink in activate script#9126
Merged
mitchellhenke merged 2 commits intomainfrom Aug 31, 2023
Merged
Use correct method to delete symlink in activate script#9126mitchellhenke merged 2 commits intomainfrom
mitchellhenke merged 2 commits intomainfrom
Conversation
added 2 commits
August 31, 2023 12:36
changelog: Bug Fixes, Service Provider Setup, Call correct method to delete symlink
bleachbyte
approved these changes
Aug 31, 2023
Contributor
bleachbyte
left a comment
bleachbyte
left a comment
There was a problem hiding this comment.
This should hopefully fix the error currently showing up in provisioning prod:
NoMethodError: undefined method `rm' for File:Class
mdiarra3
approved these changes
Aug 31, 2023
mitchellhenke
deleted the
mitchellhenke/use-correct-file-rm-in-activateclear
branch
mdiarra3
pushed a commit
that referenced
this pull request
Aug 31, 2023
* add failing spec * Call correct method to delete symlink changelog: Bug Fixes, Service Provider Setup, Call correct method to delete symlink
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
In #8786, we added a section of code to delete invalid symlinks, but it used the wrong method to call for the deletion. This PR adds a spec to cover the behavior and fixes the bug by calling
FileUtils.rminstead ofFile.rm(which does not exist)This PR slightly refactors some of the methods and makes some of them public so it is easier to interact with in the tests.