Skip to content

LG-10832: Pass enrollments with supported secondary ID type#9123

Merged
tomas-nava merged 1 commit intomainfrom
tomas/lg-10832-pass-visual-inspection-enrollments
Aug 31, 2023
Merged

LG-10832: Pass enrollments with supported secondary ID type#9123
tomas-nava merged 1 commit intomainfrom
tomas/lg-10832-pass-visual-inspection-enrollments

Conversation

@tomas-nava
Copy link
Contributor

@tomas-nava tomas-nava commented Aug 30, 2023

🎫 Ticket

LG-10832

🛠 Summary of changes

Passes enrollments with a secondary ID, only if it has a type of "Visual Inspection of Name and Address on Primary ID Match"

📜 Acceptance testing plan

Once this PR is merged and in dev

  • Create a new account via the OIDC application
  • Complete the in-person proofing process through to the barcode page
  • Ask USPS to set a completed proof status for your enrollment code (passed, and with a secondary ID type of "Visual Inspection of Name and Address on Primary ID Match")
  • Confirm that your enrollment is successfully passed

changelog: User-Facing Improvements, In-person Proofing, Pass enrollments with supported secondary ID types
@tomas-nava tomas-nava requested review from a team and svalexander August 30, 2023 22:37
"fraudSuspected": false,
"proofingConfirmationNumber": "350040248346701",
"ippAssuranceLevel": "1.5"
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just reformatting this file, no content change

Copy link
Contributor

@allthesignals allthesignals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"State non-driver's identification card",
]
SUPPORTED_SECONDARY_ID_TYPES = [
'Visual Inspection of Name and Address on Primary ID Match',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could reuse this in the fixture

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you can evaluate constants in the fixture files

Copy link
Contributor

@racingspider racingspider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tomas-nava tomas-nava merged commit b46f45a into main Aug 31, 2023
@tomas-nava tomas-nava deleted the tomas/lg-10832-pass-visual-inspection-enrollments branch August 31, 2023 15:44
@mdiarra3 mdiarra3 mentioned this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants