Fix 500 with blank token when attempting to update service providers#9102
Merged
mitchellhenke merged 2 commits intomainfrom Aug 30, 2023
Merged
Fix 500 with blank token when attempting to update service providers#9102mitchellhenke merged 2 commits intomainfrom
mitchellhenke merged 2 commits intomainfrom
Conversation
zachmargolis
approved these changes
Aug 28, 2023
added 2 commits
August 28, 2023 14:02
changelog: Bug Fixes, Dashboard Integration, Fix 500 with blank token when attempting to update service providers
mitchellhenke
force-pushed
the
mitchellhenke/no-500-on-nil-auth
branch
from
6451f6c to
04f2c3a
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
During last week's contingency planning scenario, we noticed some unrelated 500s when comparing a nil value.
This PR skips the comparison if the value is blank. This should be fine since an attempted timing attack with a zero-length attempt should not be terribly informative.