Skip to content

LG-10657 move pii from doc out of flow session STEP 1#9120

Merged
soniaconnolly merged 5 commits intomainfrom
LG-10657-Move-pii_from_doc-out-of-flow_session
Aug 30, 2023
Merged

LG-10657 move pii from doc out of flow session STEP 1#9120
soniaconnolly merged 5 commits intomainfrom
LG-10657-Move-pii_from_doc-out-of-flow_session

Conversation

@soniaconnolly
Copy link
Contributor

@soniaconnolly soniaconnolly commented Aug 30, 2023

🎫 Ticket

LG-10657

🛠 Summary of changes

Start the process of moving :pii_from_doc into idv_session. Incidentally clean up some controller spec flow_session values that are no longer used.

Plan:

  1. Align on :pii_from_doc as flow_session key, replacing 'pii_from_doc' where needed (this PR)
  2. Make as many reads as possible go through pii_from_doc method in IdvStepConcern (this PR)
  3. Move ssn out of pii_from_doc into idv_session, possibly into applicant, or its own key (two separate PRs, LG-10886)
  4. Copy pii_from_doc into idv_session (are there session size issues with this?) (future PR)
  5. Remove flow_session[:pii_from_doc] (future PR)

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Create account, go through IdV
  • On VerifyInfo step, edit address and SSN.
  • Expect profile to be created correctly.

@soniaconnolly soniaconnolly requested a review from a team August 30, 2023 19:36
[skip changelog]
Copy link
Contributor

@kbighorse kbighorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾

Copy link
Contributor

@jmax-gsa jmax-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup.

@soniaconnolly soniaconnolly merged commit 266900f into main Aug 30, 2023
@soniaconnolly soniaconnolly deleted the LG-10657-Move-pii_from_doc-out-of-flow_session branch August 30, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants