Lg 10556 move error message out of flow session 2 of 2#9104
Merged
Conversation
[skip changelog]
Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
…id handoff Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
soniaconnolly
approved these changes
Aug 29, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM. Tested locally and the error messages show up for canceling hybrid_mobile document upload and for getting rate limited for sending a link.
We removed specs & code for showing an error message in Agreement and GettingStarted pages with js disabled, as @aduth recommended.
kbighorse
deleted the
LG-10556-Move-error_message-out-of-flow_session_2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10556
🛠 Summary of changes
This PR is the follow-up PR to remove code that displays
flow_sessionerror messages to the user.📜 Testing Plan
Provide a checklist of steps to confirm the changes.
/test/telephonyin a new incognito window