LG-10302: Change Address Search i18n lib#9109
Merged
allthesignals merged 2 commits intomainfrom Aug 29, 2023
Merged
Conversation
allthesignals
commented
Aug 29, 2023
Comment on lines
-248
to
+252
| <I18nContext.Provider | ||
| value={ | ||
| new I18n({ | ||
| strings: { | ||
| 'in_person_proofing.body.location.po_search.results_description': { | ||
| one: 'There is one participating Post Office within 50 miles of %{address}.', | ||
| other: | ||
| 'There are %{count} participating Post Offices within 50 miles of %{address}.', | ||
| }, | ||
| }, | ||
| }) | ||
| } | ||
| > | ||
| context('pluralized and singularized translations are set', () => { | ||
| usePropertyValue(i18n, 'strings', { | ||
| 'in_person_proofing.body.location.po_search.results_description': { | ||
| one: 'There is one participating Post Office within 50 miles of %{address}.', | ||
| other: 'There are %{count} participating Post Offices within 50 miles of %{address}.', | ||
| }, | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
Because we aren't using the Provider to set the translation values, we instead override the locale data in the i18n global using usePropertyValue test helper, which resets the original values later.
aduth
approved these changes
Aug 29, 2023
| { | ||
| "name": "@18f/identity-address-search", | ||
| "version": "1.0.5", | ||
| "version": "2.0.0", |
Contributor
There was a problem hiding this comment.
Is this change expected here? I suppose it shouldn't matter much if it's already in main via #9103.
Contributor
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
🛠 Summary of changes
Swap in less React-ish i18n lib so consumer app (Help Center) can more simply supply its own translations.
📜 Testing Plan
Refactor should result in no changes.