Merged
Conversation
We are migrating to a new KMS instance for encryption that supports multi-region keys. We will need to encrypt and decrypt ciphertexts with both the current single region key and the new multi-region key. To support that the KMS client will need to be able to be configured for one of the given keys. This commit adds the ability to specify a key ID to use for the KMS client. To preserve the original behavior as the new key is being phased in the KMS client uses the old single region key if no key is specified. [skip changelog]
These keys were at forms.verify_profile, but relate entirely to the GPO experience. Moving them to idv.gpo. [skip changelog]
* update test deps * stricter accessibility testing changelog: Internal, Accessibility Testing, Use stricter checks in accessibility testing --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
changelog: Upcoming Features, Face or Touch Unlock, Capitalize "Add face or touch unlock" consistently with other MFA methods
changelog: Internal, Database, Remove reference to dropped profiles.reproof_at database column
Add validate_idv_completed_page(user) and validate_return_to_sp to idv_helper End to end specs help us validate that profile changes will not break IdV in production. [skip changelog]
* update string to remove double period * changelog: User-Facing Improvements, Barcode page, update es translation
We are working on migrating to a multi-region capable KMS key. As part of the migration we will be temporarily writing ciphertexts encrypted with the current KMS key and the new multi-region key. This commit makes a change to the PII encryptor such that it encrypts with the multi-region key when the `aws_kms_multi_region_write_enabled` flag is set. This will cause a multi-region ciphertext to be returned and written to the database. [skip changelog]
* Update testing libraries changelog: Internal, Continuous Integration, Update testing libraries Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update spec/support/features/webauthn_helper.rb --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Update rubocop-rails and other test/dev dependencies changelog: Internal, Dependencies, Update test and development dependencies
changelog: Bug Fixes, Authentication, Ensure PIV/CAC authentications check rules of use
* LG-10484: Add uuid-export in data-pull script changelog: Internal, Reporting, Add uuid-export in data-pull script * Update lib/data_pull.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Remove octokit, rails-erd and binding_of_caller from Gemfile changelog: Internal, Dependencies, Remove unused octokit, rails-erd, and binding_of_caller gems from Gemfile * remove rails-erd * and binding of caller
* LG-10610 Mark FSM SSN step complete in non-FSM SSN * changelog: Upcoming Features, In-person proofing, Mark FSM SSN step complete upon hitting the non-FSM SSN step
* add in_person_verification_needed argument to profile_maker#save_profile we no longer pass in_person_verification_pending to the initialize method for profile maker Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * added profile#deactivate_for_in_person_verification added this method and split from profile#deactivate_for_in_person_verification_and_schedule_enrollment * profile#activate_after_passing_in_person nils out in person timestamp * use new profile#deactivate_for_in_person_verification method * separated schedule and deactivate for ipp in gpo verify form * removed profile#deactivate_for_in_person_verification_and_schedule_enrollment removed this method as coupling them didn't work when creating a profile for phone finder. * change in_person_enrollment to pending_in_person_enrollment in idvsession * add changelog changelog: Internal, IdV IPP, write to in_person_verification_pending_at * fixup * add in_person_verificaion_needed to personal key spec * rename to pending_in_person_enrollment * added in_person_verification_pending_at to specs * remove attr accessor for in_person * to_not be_nil -> to be_present --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
mitchellhenke
approved these changes
Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features