Update rubocop-rails and other testing/development gems#8961
Merged
mitchellhenke merged 6 commits intomainfrom Aug 9, 2023
Merged
Update rubocop-rails and other testing/development gems#8961mitchellhenke merged 6 commits intomainfrom
mitchellhenke merged 6 commits intomainfrom
Conversation
mitchellhenke
commented
Aug 8, 2023
config/application.yml.default
Outdated
Contributor
Author
There was a problem hiding this comment.
This is necessary because of this change in webmock
Without it, it will fail to parse the URL and raise an error like the following:
expected UspsInPersonProofing::Exception::RequestEnrollException, got #
<RSpec::Mocks::MockExpectationError:"#<ActiveSupport::Logger:0x0000000125656e60 @level=0,
@progname=..."Exception raised while enrolling user:
Absolute URI missing hierarchical segment: 'http://:80'\")"> with backtrace:
mitchellhenke
commented
Aug 8, 2023
Comment on lines
-10
to
-15
Contributor
Author
There was a problem hiding this comment.
As of Rails 7, returning in a transaction will rollback, which is not the intended behavior in this method, though it does not affect it since there is no prior change we'd want applied.
The new Rails/TransactionExitStatement caught it. A test was added below to check that it works correctly.
added 6 commits
August 8, 2023 17:41
changelog: Internal, Dependencies, Update test and development dependencies
mitchellhenke
force-pushed
the
mitchellhenke/update-test-deps
branch
from
07346b0 to
1f13487
Compare
aduth
approved these changes
Aug 9, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for the explainer comments
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
In working on #8932, I realized that we haven't updated our test/dev dependencies in a while.
rubocop-railsis the most significant one, but I've updated other ones as well.One of the new checks that I did not enable, but fixed a few of the errors is Rails/ActionControllerFlashBeforeRender as it had a few false positives because it can't handle conditionals across methods. This is one of the situations where it sees a call to flash without a redirect, but it's fine because it is located elsewhere. We could think about enabling it, but it would mean ignoring in a handful of places and/or doing some refactoring.