LG-10484: Add uuid-export in data-pull script#8967
Merged
olatifflexion merged 2 commits intomainfrom Aug 9, 2023
Merged
Conversation
changelog: Internal, Reporting, Add uuid-export in data-pull script
zachmargolis
approved these changes
Aug 9, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM!! one small comment
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Merged
aduth
reviewed
Aug 11, 2023
| ['does-not-exist', '[NOT FOUND]', '[NOT FOUND]', '[NOT FOUND]'], | ||
| ] | ||
|
|
||
| expect(result.table).to eq(expected_table) |
Contributor
There was a problem hiding this comment.
I hit some flakiness with this spec today in an unrelated pull request:
Contributor
There was a problem hiding this comment.
Doesn't seem like any sort would be guaranteed on the order of how users are listed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-10484
🛠 Summary of changes
Update the data-pull script in the IDP so that we can get the external partner UUIDs for a user
👀 Screenshots