Skip to content

Remove octokit, rails-erd, and binding_of_caller from Gemfile#8969

Merged
mitchellhenke merged 3 commits intomainfrom
mitchellhenke/remove-octokit
Aug 9, 2023
Merged

Remove octokit, rails-erd, and binding_of_caller from Gemfile#8969
mitchellhenke merged 3 commits intomainfrom
mitchellhenke/remove-octokit

Conversation

@mitchellhenke
Copy link
Contributor

@mitchellhenke mitchellhenke commented Aug 9, 2023

🛠 Summary of changes

We removed the code that used octokit in #5038, but the dependency is still installed in development. This PR removes it.

rails-erd was added in #625, but the documentation was removed in #4960.

binding_of_caller has been around since #1, and has not been used for some time as far as I can tell 🙂

@mitchellhenke mitchellhenke requested a review from a team August 9, 2023 17:55
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find! LGTM

@mitchellhenke mitchellhenke force-pushed the mitchellhenke/remove-octokit branch from c454ca1 to 79d4d4d Compare August 9, 2023 17:58
@mitchellhenke
Copy link
Contributor Author

mitchellhenke commented Aug 9, 2023

@zachmargolis I removed another one (rails-erd) 😬

edit: and binding_of_caller

Mitchell Henke added 3 commits August 9, 2023 13:00
changelog: Internal, Dependencies, Remove unused octokit, rails-erd, and binding_of_caller gems from Gemfile
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/remove-octokit branch from 45c9fbf to 97f7fb5 Compare August 9, 2023 18:00
@mitchellhenke mitchellhenke changed the title Remove octokit from Gemfile Remove octokit, rails-erd, and binding_of_caller from Gemfile Aug 9, 2023
@mitchellhenke mitchellhenke merged commit 4ac5661 into main Aug 9, 2023
@mitchellhenke mitchellhenke deleted the mitchellhenke/remove-octokit branch August 9, 2023 18:18
@jmhooper jmhooper mentioned this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants