Update selenium and capybara to fix chromedriver issues#8956
Merged
mitchellhenke merged 11 commits intomainfrom Aug 8, 2023
Merged
Update selenium and capybara to fix chromedriver issues#8956mitchellhenke merged 11 commits intomainfrom
mitchellhenke merged 11 commits intomainfrom
Conversation
Contributor
Could we trim the value we set? |
mitchellhenke
force-pushed
the
mitchellhenke/update-selenium
branch
from
43780e5 to
a597541
Compare
added 7 commits
August 8, 2023 13:47
changelog: Internal, Continuous Integration, Update testing libraries
Contributor
Author
I swear I did try that and it failed, but I tried again and it does work. I've removed my fork and have added the new line removals with a comment explaining why. |
mitchellhenke
force-pushed
the
mitchellhenke/update-selenium
branch
from
a597541 to
3dab8b1
Compare
zachmargolis
reviewed
Aug 8, 2023
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
zachmargolis
approved these changes
Aug 8, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
The issues presented by #8942 require a bit of a deeper set of changes to fix for now.
As of
selenium-webdriverversion 4.11.0 manages its own browser driver management and the webdrivers gem is deprecated. The update to 4.11.0 broke capybara's usage of selenium, which was patched in capybara 3.39.1.Unfortunately, capybara 3.39.0 breaks some of our tests as it includes a change that auto-submits forms if you set a value that ends in a
"\n"as we do here. I've forked and created a branch to undo that specific change and brought it in to this pull request. I've also opened teamcapybara/capybara#2696 with a different patch to try to maintain some of the intended functionality.