Updating scan step to handle nulls#8963
Merged
stephencshelton merged 1 commit intomainfrom Aug 9, 2023
Merged
Conversation
stephencshelton
force-pushed
the
sshelton/fix-null-scans
branch
from
e03a6ce to
8d35f59
Compare
timothy-spencer
approved these changes
Aug 9, 2023
Contributor
timothy-spencer
left a comment
timothy-spencer
left a comment
There was a problem hiding this comment.
I wish there was a way for all of these to share code, but I can't think of any simple way to do that. :-) Approved!
Contributor
Author
|
Yeah that's one of the big things I liked about argo workflows, you can make a single workflow template and share it across all the pipelines you run in that namespace. Makes updates to images etc a little easier when you have a golden pipeline step everyone can consume. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Handles a case where if findings is null the scan step will fail. Related work located HERE where the behavior has been tested