Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/update-accessibility-tests
branch
from
d789a7c to
cd1ec84
Compare
aduth
reviewed
Aug 7, 2023
app/javascript/packages/document-capture/components/file-input.tsx
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
The logic is a little more complex because this is also within a condition a few lines above !value && !isValuePending which controls whether the "inner" hint is rendered.
Contributor
There was a problem hiding this comment.
We could probably make this a simple variable (and colocate with hintId and friends above):
const showInnerHint = !value && !isValuePending && isMobile && !!bannerText;
Contributor
Author
There was a problem hiding this comment.
had to switch to ! isMobile
mitchellhenke
force-pushed
the
mitchellhenke/update-accessibility-tests
branch
3 times, most recently
from
f2388c8 to
f320a0c
Compare
aduth
reviewed
Aug 7, 2023
app/javascript/packages/document-capture/components/file-input.tsx
Outdated
Show resolved
Hide resolved
changelog: Internal, Accessibility Testing, Use stricter checks in accessibility testing
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
….tsx Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
mitchellhenke
force-pushed
the
mitchellhenke/update-accessibility-tests
branch
from
3950be6 to
ffe0c7a
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
The
be_axe_cleancheck is included in thehave_no_accessibility_violationscheck. The latter also includes other tests for accessibility, and caught one hanging tag that this PR removes. Thehave_valid_idrefscheck was also updated to handle multiple tags being referenced in the attribute as it was incorrectly failing in some places where we do that.