LG-0385 Write to in_person_verification_pending_at timestamp.#8960
Merged
LG-0385 Write to in_person_verification_pending_at timestamp.#8960
Conversation
we no longer pass in_person_verification_pending to the initialize method for profile maker Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
added this method and split from profile#deactivate_for_in_person_verification_and_schedule_enrollment
changelog: Internal, IdV IPP, write to in_person_verification_pending_at
kbighorse
approved these changes
Aug 8, 2023
Contributor
kbighorse
left a comment
kbighorse
left a comment
There was a problem hiding this comment.
question:
We now have the following:
User#pending_in_person_enrollmentIdv::GpoVerifyController#pending_in_person_enrollment?(calls 1.)Profile#pending_in_person_enrollment?(callsProfile#proofing_components)Idv::Session#pending_in_person_enrollment?(callsUser#proofing_component)
Is there a way to consolidate/differentiate some of this? Might be worth some future consideration.
Otherwise 👍🏾 🚀
| if in_person_verification_pending | ||
| profile.deactivation_reason = :in_person_verification_pending | ||
| end | ||
| profile.deactivate_for_in_person_verification if in_person_verification_needed |
Contributor
There was a problem hiding this comment.
app/models/profile.rb
Outdated
| # note: deactivation reason will be replaced by timestamp column | ||
| deactivation_reason == 'in_person_verification_pending' | ||
| deactivation_reason == 'in_person_verification_pending' || | ||
| in_person_verification_pending_at? |
Contributor
There was a problem hiding this comment.
This is reading rather than writing. Are we ready to start reading the new value?
|
|
||
| expect(profile.activated_at).to be_nil | ||
| expect(profile.active).to eq(false) | ||
| expect(profile.deactivation_reason).to eq('in_person_verification_pending') |
Contributor
There was a problem hiding this comment.
Should there be an expectation for profile.in_person_verification_pending_at on this spec and the others in this file?
kbighorse
suggested changes
Aug 9, 2023
spec/models/profile_spec.rb
Outdated
| expect(profile.deactivation_reason).to eq 'in_person_verification_pending' # to change | ||
| expect(profile.fraud_review_pending?).to eq(true) # to change | ||
| expect(profile.gpo_verification_pending_at).to be_nil | ||
| expect(profile.in_person_verification_pending_at).to_not be_nil |
Contributor
There was a problem hiding this comment.
add this before and after test throughout the other tests
kbighorse
approved these changes
Aug 9, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10383
🛠 Summary of changes
We are deprecating the
profile#deactivation_reason(:in_person_verification_pending)enum for a in_person_verification_pending_at timestamp. This PR will write to both for now until we complete a backfill to add timestamps to all users who are undergoing in person verification.