LG-9208: Confirm password by jc-gsa · Pull Request #8220 · 18F/identity-idp

jc-gsa · 2023-04-14T23:30:03Z

🎫 Ticket

LG-9208

🛠 Summary of changes

Adds a password confirmation component to the user registration flow. Adds both front-end and back-end validations.

It is important to ensure that no other flows are inadvertently disrupted.

Older code was refactored as it was encountered, particularly tests.

changelog: User-Facing Improvements, Registration, Add password confirmation

aduth · 2023-04-18T12:19:55Z

There's some merge conflicts here that need to be resolved. I suspect they're related to changes in #8085.

app/javascript/packages/password-confirmation/package.json

app/javascript/packages/password-toggle/package.json

app/components/password_confirmation_component.html.erb

app/javascript/packages/password-confirmation/password-confirmation-element.ts

app/controllers/sign_up/passwords_controller.rb

changelog: Internal, Caching, Use ActiveSupport cache version 7.0

… is created (#8113) * add usps doc check to proofing component earlier changelog: Internal, refactor, in-person VerifyInfoController outside Flow State Machine * include Steps::ThreadMetricStepHelper (see #7924) * replace IdvSession with IdvStepConcern (see #7840) and remove redundant confirm_two_factor_authenticate (see #8082) * give in-person verify info controller its own view and fix links to update pages * move process_async_state into the concern

* saml_2022 -> saml_2023; remove saml_2021 stuff * changelog: Internal, SAML, remove saml2021 references (identity-devops#5739) * update example cert files in config/artifacts.example/local/ - remove the old saml2021 .crt and .key.enc files as they're no longer used/valid - change saml2023 .crt and .key.enc to actual files (vs. symlinks), newly created with openssl req -newkey (etc.) changelog: Internal, SAML, remove saml2021 references (identity-devops#5739) * Update specs to 2023 * Replace auth2022 Command: git grep -l auth2022 -- spec | xargs perl -p -i -e 's/auth2022/auth2023/g' -- * Replace logout2022 git grep -l logout2022 -- spec | xargs perl -p -i -e 's/logout2022/logout2023/g' -- * Update authpost2022 git grep -l authpost2022 -- spec | xargs perl -p -i -e 's/authpost2022/authpost2023/g' * Update one last spec --------- Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov>

* Fix link to help center Link "Learn more about what phone number to use" to https://login.gov/help/verify-your-identity/phone-number/ [skip changelog] * Fix size of "Verify by mail " button

…tion (#8123) Combine the versions of confirm_document_capture_complete in IdvStepConcern (used by SsnController) and in AddressController. This will make it easier to continue updating that method as we continue adding functionality to DocumentCaptureController. Added method pii_from_doc to IdvStepConcern pii is no longer an instance variable and no longer memoized in SsnController and AddressController The long term plan is to move all the step-related before actions and methods to IdvStepConcern Move flow_session and flow_path to IdvStepConcern changelog: Internal, Flow State Machine replacement, combine similar before actions --------- Co-authored-by: Douglas Price <douglas.price@gsa.gov>

[skip changelog]

changelog: Internal, Attempts API, Batch Job improvements

* re-add saml2021* files to AppArtifacts.setup, for now * changelog: Internal, SAML, re-add saml2021 references (identity-devops#5739) * re-add saml2021 files to config/artifacts.example/local/ changelog: Internal, SAML, remove saml2021 references (identity-devops#5739)

mdiarra3 · 2023-04-24T16:56:39Z

why are there 118 commits in ur branch this is weird.

app/forms/password_confirmation_form.rb

app/javascript/packages/password-confirmation/password-confirmation-element.spec.ts

app/javascript/packages/password-toggle/package.json

app/views/sign_up/passwords/new.html.erb

aduth

Left a few, mostly minor remarks, but functionally this works great 👍

app/views/sign_up/passwords/new.html.erb

app/controllers/sign_up/passwords_controller.rb

app/components/password_confirmation_component.html.erb

app/javascript/packages/password-confirmation/password-confirmation-element.spec.ts

app/components/password_confirmation_component.html.erb

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

…p into LG-9208-confirm-password # Conflicts: # app/controllers/sign_up/passwords_controller.rb # app/forms/password_form.rb # spec/forms/password_form_spec.rb

app/forms/password_form.rb

app/components/password_confirmation_component.html.erb

spec/controllers/sign_up/passwords_controller_spec.rb

app/validators/form_password_validator.rb

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

…p into LG-9208-confirm-password

aduth

LGTM 👍

Will you create the follow-on pull request to remove the code for managing the mid-deploy state?

Separately, I'm going to create a ticket to explore password form improvements like using [autocomplete="new-password"] and a hidden input for the email address, with the hopes that it could provide the user an option to auto-fill a generated password and prompt to save the password. This hasn't existed previously either, but I think having a confirmation field makes this problem more acute, since even if someone uses a password manager they'll have to manually insert that password into each of the two fields (or at least that was my experience in testing this).

Edit: For posterity, the tickets are LG-9709 and LG-9710.

jc-gsa · 2023-05-04T16:27:43Z

@aduth LG-9714 has been created to remove the 'feature flag'.

jc-gsa added 15 commits April 5, 2023 17:36

Add draft confirmation component

1f2b804

Add translations

c0c69e0

Add various notices

314de59

Add stash WIP password-confirmation package

a229005

Add spec

4f1af11

Add initial back-end validation

71f861a

Add tests

43b42fa

Add refactor

aea8907

Add PasswordConfirmationForm

52099ad

Update FormPasswordValidator

2251943

Add tests

ef475a3

Update session_helper

43eb800

Add WIP

ccc7b11

Update tests, refactor

f723aa8

Update tests

ab97289

jc-gsa force-pushed the LG-9208-confirm-password branch from e929d3d to ab97289 Compare April 17, 2023 05:48

jc-gsa added 2 commits April 17, 2023 16:02

Add refactor

5cbf908

changelog: User-Facing Improvements, Registration, Add password confirmation

Consolidate translation keys

96f726d

jc-gsa requested a review from a team April 17, 2023 21:24

aduth reviewed Apr 18, 2023

View reviewed changes

jc-gsa and others added 9 commits April 18, 2023 17:09

Add name changes

715baba

Use ActiveSupport cache version 7.0 (#8126)

acffb17

changelog: Internal, Caching, Use ActiveSupport cache version 7.0

LG-9026: Additional cleanup (#8127)

3ace4b0

* Fix link to help center Link "Learn more about what phone number to use" to https://login.gov/help/verify-your-identity/phone-number/ [skip changelog] * Fix size of "Verify by mail " button

LG-8932: Fix check for state vs residential address; update test (#8124)

7cd847b

[skip changelog]

LG-9146 Fix intermittent infinity loop (#8133)

c15a5ca

changelog: Internal, Attempts API, Batch Job improvements

jc-gsa force-pushed the LG-9208-confirm-password branch from 8db0ceb to 49e9863 Compare April 21, 2023 00:01

Clear validations

017b3c2

jc-gsa force-pushed the LG-9208-confirm-password branch from 49e9863 to 017b3c2 Compare April 21, 2023 00:02

mdiarra3 approved these changes Apr 24, 2023

View reviewed changes

aduth reviewed Apr 24, 2023

View reviewed changes

Add refactor

b3774fc

jc-gsa force-pushed the LG-9208-confirm-password branch from 18d7be4 to b3774fc Compare April 24, 2023 20:57

aduth approved these changes Apr 25, 2023

View reviewed changes

jc-gsa and others added 7 commits April 25, 2023 11:27

Update app/components/password_confirmation_component.html.erb

ee6881d

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

Update app/components/password_confirmation_component.html.erb

a7f58db

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

Add refactor

8a15d37

Merge branch 'LG-9208-confirm-password' of github.com:18F/identity-id…

b260d4e

…p into LG-9208-confirm-password # Conflicts: # app/controllers/sign_up/passwords_controller.rb # app/forms/password_form.rb # spec/forms/password_form_spec.rb

Add feature flag password_confirmation_enabled

7974fd7

Merge branch 'main' into LG-9208-confirm-password

28098e9

Change flag to confirmation_enabled

079938f

aduth reviewed May 2, 2023

View reviewed changes

jc-gsa and others added 5 commits May 2, 2023 13:43

Update app/components/password_confirmation_component.html.erb

cb00c49

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

Add refactor

9a1998a

Merge branch 'LG-9208-confirm-password' of github.com:18F/identity-id…

84f21ad

…p into LG-9208-confirm-password

Yaml

622efe8

Merge branch 'LG-9208-confirm-password' of github.com:18F/identity-id…

a798714

…p into LG-9208-confirm-password

jc-gsa force-pushed the LG-9208-confirm-password branch from b553b88 to a798714 Compare May 2, 2023 20:17

aduth approved these changes May 4, 2023

View reviewed changes

jc-gsa merged commit f85363f into main May 4, 2023

jc-gsa deleted the LG-9208-confirm-password branch May 4, 2023 16:31

soniaconnolly mentioned this pull request May 8, 2023

Deploy RC 278 to Prod #8360

Merged

aduth mentioned this pull request Dec 18, 2023

Add missing spec assertion for password change user event #9781

Merged

Conversation

jc-gsa commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎫 Ticket

🛠 Summary of changes

Uh oh!

aduth commented Apr 18, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdiarra3 commented Apr 24, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aduth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aduth left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jc-gsa commented May 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

jc-gsa commented Apr 14, 2023 •

edited

Loading

aduth left a comment •

edited

Loading