Add missing spec assertion for password change user event#9781
Merged
Conversation
changelog: Internal, Automated Testing, Add missing spec assertion for password change user event
aduth
commented
Dec 18, 2023
| patch :update, params: { update_user_password_form: params } | ||
| params = { | ||
| password: 'salty new password', | ||
| password_confirmation: 'salty new password', |
Contributor
Author
There was a problem hiding this comment.
The addition of password_confirmation here is due to some code drift where we added the requirement to enter the new password twice in #8220. Since we weren't verifying anything in this spec previous, this test never began failing when adding that requirement.
mdiarra3
approved these changes
Dec 18, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Adds an assertion to a test case intended to verify that a user event is created upon successful password change.
Previously, this spec would only do the set up to invoke the password change, but didn't include any assertions.
This was noticed in putting together #9780 and looking for examples of other user event spec verifications.
📜 Testing Plan