Merged
Conversation
changelog: Internal, Source code, Update example bucket name
) Adds the vendor_status_lexisnexis_phone_finder flag, which when set to full_outage will force the user through the mail-only flow. The user is shown the mail only warning page prior to starting IdV. The hybrid flow is still available. changelog: User-Facing Improvements, Vendor outage, Phone Finder outage flag Co-authored-by: Eric Gade <eric.gade@gsa.gov>
changelog: Internal, Attempts API, Log events for fraud rejection (LG-8664) --------- Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Add bad_password_count to analytics event email_and_password_auth [skip changelog]
* Add read option to request module to allow raw response * Update document capture to use request utility changelog: Bug Fixes, Form Submission, Refresh form authenticity token when user's session is renewed with "Keep me signed in" * Remove unused union type From earlier iteration * Update upload-spec.jsx * Update upload-spec.js * Document capture is not JSON
* Update user language preference on registration changelog: User-Facing Improvements, Registration, Update user confirmation email language
changelog: Internal, Performance, Reduce size of stylesheet assets
* Move confirm_profile_not_already_confirmed to IdvStepConcern In a post-FSM world we want all the logic about redirects between steps to be in IdvStepConcern. Include this method in the pattern, and include IdvStepConcern in SsnController. Also remove redundant calls to `confirm_two_factor_authenticated` before action since it is included by IdvStepConcern. * Rename confirm_profile_not_already_confirmed to confirm_verify_info_step_needed Note that in_person/verify_info_controller has its own implementation which was also renamed. * Move confirm_pii_from_doc to IdvStepConcern Note that AddressController has its own slightly different implementation of this method. * Rename `confirm_pii_from_doc` to `confirm_document_capture_complete` including in AddressController changelog: Internal, Identity Verification, Refactor code that moves between steps
Note that Funnel::DocAuth::RegisterStep still refers to send_link and the doc_auth_logs table still has columns for send_link_view_at and send_link_view_count changelog: Internal, Identity Verification, Remove final references to SendLinkStep
…8084) * Remove redundant "remaining" value from timeout API changelog: Internal, Session Timeout, Remove redundant timeout value from session timeout API * Revert session API remaining removal Temporary for first deploy, see https://github.com/18F/identity-idp/pull/8084/files#r1150918192 * Optimistically hide modal on session continue 1. Fixes specs 2. Better user experience, don't have to wait for request to finish before modal is closed, thus making app feel more responsive 3. The previous result handling with `success` would cause a second polling interval to begin * Bring over rest of spec changes from #7966 The CSRF won't be updated until after the request finishes, even if the modal will be disappeared immediately
* add redirect for users with rejected profiles * add test in auth controller for fraud review pending redirect * add controller and view for verify errors * add fraud_rejection redirects * create verify failure page * add test for verify_errors_controller * add analytics event for verify errors visited * add tests to check redirects * add changelong changelog: User-Facing Improvements, IdV, New fraud rejection page for users * lints * fraud before actions placed in concern * move verify_errors to not_verified * remove external link and Exit Login.gov * add handle fraud before action * check for fraud in errors controllers * remove before actions
* add strings and pull address into separate file * update headings i18n * add heading for remote and remove conditionals for headings * remove address component as this is out of scope * only show changes for enrollments where capture_secondary_id_enabled is true * specs for verify step * fix verify spec * fix lint and doc auth spec failure * changelog: User-Facing Improvements, Verify your info, update sections * remove div and nil check * lint fix * add padding to titles and update
aduth
requested review from
eric-gade,
jc-gsa,
jmhooper,
n1zyy,
solipet,
soniaconnolly,
svalexander,
theabrad and
zachmargolis
mitchellhenke
approved these changes
Mar 29, 2023
* Update users:review:pass task to handle nil/missing data (LG-9271) * Update users:review:reject to handle nil/missing data changelog: Internal, Fraud review, Update fraud review tasks to handle nil/missing data --------- Co-authored-by: Amir Reavis-Bey <amirbey@users.noreply.github.com> Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Sonia Connolly <soniaconnolly@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal