Update document capture to use request utility#8072
Merged
Conversation
changelog: Bug Fixes, Form Submission, Refresh form authenticity token when user's session is renewed with "Keep me signed in"
From earlier iteration
Contributor
Author
|
There's some failing tests I'll need to work through. Reverting to draft for now. |
Contributor
Author
|
Tests should hopefully be fixed now. Just needed to sync them to (1) new expectation that CSRF is not an implementation detail of the document capture's upload and (2) use real |
mitchellhenke
approved these changes
Mar 24, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates fetch usage in document capture to use the
@18f/identity-requestutility.Why?
csrfReact context value@18f/identity-requestto support use-case of raw response handling📜 Testing Plan