Remove final references to send_link step

[soniaconnolly]

🎫 Ticket

Tail end of LG-8903

🛠 Summary of changes

The Send Link Step was removed in favor of the Combined Hybrid Handoff screen. This removes some remaining references to that step.

Note that Funnel::DocAuth::RegisterStep still refers to send_link and the doc_auth_logs table still has columns for send_link_view_at and send_link_view_count.

[aduth]

Note that Funnel::DocAuth::RegisterStep still refers to send_link and the doc_auth_logs table still has columns for send_link_view_at and send_link_view_count.

Will those be removed?

[soniaconnolly]

Note that Funnel::DocAuth::RegisterStep still refers to send_link and the doc_auth_logs table still has columns for send_link_view_at and send_link_view_count.

Will those be removed?

I left them in because I'm not sure they can be removed. I'm assuming we want to keep past data about visitors to the SendLink step, so the db column stays, and then I'm guessing the send_link accessor is needed to query for data. @zachmargolis, do you have any thoughts about that, or how this is usually handled when steps are deleted from the FSM?

[zachmargolis]

Note that Funnel::DocAuth::RegisterStep still refers to send_link and the doc_auth_logs table still has columns for send_link_view_at and send_link_view_count.

Will those be removed?

I left them in because I'm not sure they can be removed. I'm assuming we want to keep past data about visitors to the SendLink step, so the db column stays, and then I'm guessing the send_link accessor is needed to query for data. @zachmargolis, do you have any thoughts about that, or how this is usually handled when steps are deleted from the FSM?

Since send_link/link_sent are not included in our report, I think we could remove them if we wanted to

[soniaconnolly]

Since send_link/link_sent are not included in our report, I think we could remove them if we wanted to

Zach and I talked and we're going to leave this part of the cleanup to a separate ticket.