LG-9136: Add sign in attempt count to analytics#8036
Merged
Conversation
jc-gsa
force-pushed
the
LG-9136-include-sign-in-attempt-count
branch
from
12fba78 to
395e0e5
Compare
[skip changelog]
jc-gsa
force-pushed
the
LG-9136-include-sign-in-attempt-count
branch
from
395e0e5 to
ffda26a
Compare
aduth
reviewed
Mar 22, 2023
Comment on lines
+232
to
+235
| success: false, | ||
| user_id: user.uuid, | ||
| user_locked_out: false, | ||
| bad_password_count: 0, |
Contributor
There was a problem hiding this comment.
Could we have a spec demonstrating where the count is greater than 0?
On a similar note, should the count consider the current submission? For example, would it be wrong in this spec that the attempt was unsuccessful (success: false 3 lines above) but the bad_password_count is 0? In other words, should the incrementing of the bad password count happen before we log the result, or at least account for it in the logging?
Contributor
Author
There was a problem hiding this comment.
Changed the approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9136