Skip to content

LG-8868: Disable phone verification due to a Phone Finder outage#8073

Merged
solipet merged 1 commit intomainfrom
eric-lg-8868
Mar 27, 2023
Merged

LG-8868: Disable phone verification due to a Phone Finder outage#8073
solipet merged 1 commit intomainfrom
eric-lg-8868

Conversation

@solipet
Copy link
Contributor

@solipet solipet commented Mar 24, 2023

🎫 Ticket

LG-8868: Disable phone verification due to a Phone Finder outage

🛠 Summary of changes

Adds the vendor_status_lexisnexis_phone_finder flag, which when set to full_outage will force the user through the mail-only flow. The user is shown the mail only warning page prior to starting IdV. The hybrid flow is still available.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Add the following to your application.yml: vendor_status_lexisnexis_phone_finder: full_outage
  • With an unverified account, log in and go to /verify
  • Observe the Mail Only warning page
  • Continue to the Welcome page
  • Continue to the Agreement page
  • Continue and observe the choice to proceed on desktop or mobile (hybrid flow)
  • Continue through the Verify step
  • Observe that we did not present the Phone Finder page, but went straight to "Want a letter?"

@solipet solipet requested a review from a team March 24, 2023 21:44
Adds the vendor_status_lexisnexis_phone_finder flag, which when set to
full_outage will force the user through the mail-only flow. The user is
shown the mail only warning page prior to starting IdV. The hybrid flow
is still available.

changelog: User-Facing Improvements, Vendor outage, Phone Finder outage flag

Co-Authored-By: Eric Gade <eric.gade@gsa.gov>
Copy link
Contributor

@soniaconnolly soniaconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

IdentityConfig.store.feature_idv_force_gpo_verification_enabled ||
OutageStatus.new.any_phone_vendor_outage?
outage_status.any_phone_vendor_outage? ||
outage_status.phone_finder_outage?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have documentation about when to set feature_idv_force_gpo_verification_enabled? Seems like it's a little complicated to set the right flags.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this is a new flag we've added. We are adding flags for both enabling/disabling vendor services (PhoneFinder, Pinpoint etc), but also for disabling/enabling "features" of our application -- gpo, hybrid flow, etc. This is on the heels of a conversation about what the on-call people would prefer to have.

We might consider a subsequent ticket that updates runbooks with these property values and their descriptions though.

@solipet solipet merged commit fd70272 into main Mar 27, 2023
@solipet solipet deleted the eric-lg-8868 branch March 27, 2023 20:28
@aduth aduth mentioned this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants