LG-9005 update verify info pg

[svalexander]

🎫 Ticket

Lg-9005

🛠 Summary of changes

This pr adds section titles for the verify your info page and adds the state id address information to the state-issued id section. These changes will only show for users for whom in_person_capture_secondary_id_enabled is true.
Shows address line 2 even if there is not value for it.

Does not currently impact team Ada. They are using app/views/idv/verify_info/show.html.erb for the verify view.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

To ensure updates are not seen:

• Make sure in_person_capture_secondary_id_enabled is false
• Walk through ipp flow and arrive at verify page, ensure no section titles are seen
  To check changes:
• Update in_person_capture_secondary_id_enabled to true
• Walk through ipp flow and arrive at verify page
• Make sure section titles are visible and that address information is included in state id section
• Make sure data input on state-id and address forms is correct

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Not enabled:

in_person_capture_secondary_id_enabled and same address:

in_person_capture_secondary_id_enabled and different address:

[aduth]

Same note.

Suggested change

	<div>
	<div>
	<dt class="display-inline"> <%= t('idv.form.address1') %>: </dt>
	<dd class="display-inline margin-left-0"> <%= pii[:address1] %> </dd>
	</div>
	<div>
	<dt class="display-inline"> <%= t('idv.form.address2') %>: </dt>
	<dd class="display-inline margin-left-0"> <%= pii[:address2] %> </dd>
	</div>
	<div>
	<dt class="display-inline"> <%= t('idv.form.city') %>: </dt>
	<dd class="display-inline margin-left-0"> <%= pii[:city] %> </dd>
	</div>
	<div>
	<dt class="display-inline"> <%= t('idv.form.state') %>: </dt>
	<dd class="display-inline margin-left-0"> <%= pii[:state] %> </dd>
	</div>
	<div>
	<dt class="display-inline"> <%= t('idv.form.zipcode') %>: </dt>
	<dd class="display-inline margin-left-0"> <%= pii[:zipcode] %> </dd>
	</div>
	</div>
	<div>
	<dt class="display-inline"> <%= t('idv.form.address1') %>: </dt>
	<dd class="display-inline margin-left-0"> <%= pii[:address1] %> </dd>
	</div>
	<div>
	<dt class="display-inline"> <%= t('idv.form.address2') %>: </dt>
	<dd class="display-inline margin-left-0"> <%= pii[:address2] %> </dd>
	</div>
	<div>
	<dt class="display-inline"> <%= t('idv.form.city') %>: </dt>
	<dd class="display-inline margin-left-0"> <%= pii[:city] %> </dd>
	</div>
	<div>
	<dt class="display-inline"> <%= t('idv.form.state') %>: </dt>
	<dd class="display-inline margin-left-0"> <%= pii[:state] %> </dd>
	</div>
	<div>
	<dt class="display-inline"> <%= t('idv.form.zipcode') %>: </dt>
	<dd class="display-inline margin-left-0"> <%= pii[:zipcode] %> </dd>
	</div>

[JackRyan1989]

@svalexander - If I go through the flow selecting that my state id is separate from my residential address, and get to the verify your information page, and then select "Update" for my State Issued ID and change my response on the radio button from "No" to "yes"; meaning that my address is the same as on my ID, the information on the Verify My Information page is not updated. Meaning the distinct addresses are still listed.

Is that outside of the scope of this ticket?

[svalexander]

@svalexander - If I go through the flow selecting that my state id is separate from my residential address, and get to the verify your information page, and then select "Update" for my State Issued ID and change my response on the radio button from "No" to "yes"; meaning that my address is the same as on my ID, the information on the Verify My Information page is not updated. Meaning the distinct addresses are still listed.

Is that outside of the scope of this ticket?

@JackRyan1989 yeh I think we're handling that next sprint in LG-9141

[JackRyan1989]

Super small HTML change, but looks good!

[JackRyan1989]

Super nit: do dt elements need to be enclosed by dl elements? MDN seems to say yes: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dt

[svalexander]

the parent of the div this is in is a dl element so I think that follows the rec.

[JackRyan1989]

Tests pass locally, UI changes look ok locally. LGTM!

[WheresHJ]

One minor comment: We should increase the spacing between the section titles (State issued ID, Current residential address) and the first list item by 8px, to better match the Figma. I know its a really small thing, but we appreciate it! Otherwise, LGTM! Thanks!