LG-6193: Enable personal key step in development environment by aduth · Pull Request #6229 · 18F/identity-idp

aduth · 2022-04-20T17:48:11Z

Why: So that a user can functionally complete the proofing process using the new IdV app.

Testing Instructions:

Navigate to http://localhost:3000
Sign in
Navigate to http://localhost:3000/verify
Complete proofing process up to and including the password entry step
After "Continue"-ing from password entry step, observe...
- Real personal key is shown on page
- You can enter personal key and continue to post-proofing flow step (account page if session associated with SP, otherwise confirmation screen)

Implementation Notes:

We are excluding users who've opted for GPO verification until LG-6082.
This is still disabled in all deployed environments, but will now be enabled by default in local development

Screenshot:

app/javascript/packages/verify-flow/index.tsx

spec/support/features/session_helper.rb

aduth · 2022-04-28T12:13:37Z

Gemfile

  gem 'aws-sdk-cloudwatchlogs', require: false
  gem 'brakeman', require: false
  gem 'bullet', '>= 6.0.2'
+  gem 'capybara-webmock', git: 'https://github.com/hashrocket/capybara-webmock.git', ref: '63d790a0'


The reason this points to git is because there are unpublished changes that we need.

Specifically: hashrocket/capybara-webmock@f3d27b1

…enderer **Why**: Because the current implementation relies on the assumption that we would only ever want to show "Submit" as the label of the last button in the flow, which is not the intention, and is not compatible with the current implementation of the personal key confirmation modal in the IdV API React implementation. Related discussion: #6229 (comment) changelog: Upcoming Features, Identity Verification, Add personal key step screen

…enderer (#6280) * Update FormStepsButton to place choice of "Submit" or "Continue" to renderer **Why**: Because the current implementation relies on the assumption that we would only ever want to show "Submit" as the label of the last button in the flow, which is not the intention, and is not compatible with the current implementation of the personal key confirmation modal in the IdV API React implementation. Related discussion: #6229 (comment) changelog: Upcoming Features, Identity Verification, Add personal key step screen * Fix spec lingering reference to personal key confirm "Submit"

Presumably we relied previously on PII being false in most cases. A handful of tests create a profile without a valid user attached to it, so now that we're assigning default PII for profiles, we should also only actually encrypt it if there's a valid user

In 259c213 we're now reliably setting default_url_options so that the URL will be generated correctly and we don't have to test path

too many tests assume it won't be there (probably a problem worth resolving)

Selenium::WebDriver::Error::ElementNotInteractableError: element not interactable

Capybara::NotSupportedByDriverError: Capybara::Driver::Base#response_headers shouldn't redirect if invalid CSP target?

changelog: Upcoming Features, Identity Verification, Add personal key step screen

So that they're enabled in test

JS browser would not have visibility to content otherwise

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

When JS is enabled, previous step triggers spinner button, and there may be a brief delay before review step is shown. Avoid spec flakiness by allowing some wait for the review path to be shown. precedent: https://github.com/18F/identity-idp/blob/e7501424b59f887aa12bd255f69de03502969fa0/spec/features/idv/proofing_components_spec.rb#L25

So that tests run against the in-production version, but we re-run personal key pages with both side of the toggle

Because it's a spinner button, we need to be able to wait for navigation to complete

zachmargolis reviewed Apr 20, 2022

View reviewed changes

app/javascript/packages/verify-flow/index.tsx Outdated Show resolved Hide resolved

aduth force-pushed the aduth-lg-6193-wire-it-up branch from 6a2850f to a736ed5 Compare April 21, 2022 13:55

aduth commented Apr 22, 2022

View reviewed changes

spec/support/features/session_helper.rb Outdated Show resolved Hide resolved

aduth force-pushed the aduth-lg-6193-wire-it-up branch from e89a7c0 to 0660117 Compare April 22, 2022 13:47

aduth mentioned this pull request Apr 22, 2022

LG-6160: Validate personal key value as case-insensitive, Crockford base32 #6240

Merged

aduth force-pushed the aduth-lg-6193-wire-it-up branch from 0660117 to c1e1bff Compare April 25, 2022 14:03

This was referenced Apr 26, 2022

Add missing costs tracking for async doc auth #6251

Merged

Fix SAML auth context handling for IAL2 strict request #6253

Merged

LG 6201 audit/implement logs #6257

Merged

aduth force-pushed the aduth-lg-6193-wire-it-up branch 3 times, most recently from ee6e7b5 to b3fe794 Compare April 28, 2022 01:10

aduth mentioned this pull request Apr 28, 2022

Add and fix spec coverage for JS-enabled, IAL2 strict doc auth #6265

Merged

aduth commented Apr 28, 2022

View reviewed changes

aduth mentioned this pull request Apr 28, 2022

Add form validation for present TOTP name #6267

Merged

aduth force-pushed the aduth-lg-6193-wire-it-up branch from ef938e8 to a9211e3 Compare April 28, 2022 15:36

aduth mentioned this pull request Apr 28, 2022

LG-6193: Integrate IdV app personal key step into proofing flow (feature-flagged) #6269

Merged

aduth force-pushed the aduth-lg-6193-wire-it-up branch from a9211e3 to 8be2414 Compare April 28, 2022 17:43

This was referenced Apr 28, 2022

Avoid redundant recovery PII encrypt in profile spec factory #6271

Merged

Add a flag to not allow a strict IAL2 user to redirect without phone proofing #6270

Merged

aduth changed the title ~~LG-6193: Integrate IdV app personal key step into proofing flow~~ LG-6193: Enable personal key step in development environment Apr 28, 2022

aduth force-pushed the aduth-lg-6193-wire-it-up branch from 8be2414 to 9fb2a18 Compare April 28, 2022 19:56

aduth mentioned this pull request Apr 28, 2022

Use stubbed profile for authorization_count_spec #6255

Merged

aduth mentioned this pull request Apr 29, 2022

Update FormStepsButton to place choice of "Submit" or "Continue" to renderer #6280

Merged

aduth force-pushed the aduth-lg-6193-wire-it-up branch from 9fb2a18 to cd982e9 Compare May 2, 2022 20:09

aduth mentioned this pull request May 3, 2022

Override default_url_options to set correct host, port in JS specs #6295

Merged

aduth and others added 25 commits May 6, 2022 11:59

Re-enable SAML handoff path assertion

8a577a3

Revert some now-hopefully-unnecessary URL -> path updates

9760e74

In 259c213 we're now reliably setting default_url_options so that the URL will be generated correctly and we don't have to test path

Require PII opt-in for profile stubs

30877b1

too many tests assume it won't be there (probably a problem worth resolving)

Force JS interactivity for non-interactable elements

3a3792b

Selenium::WebDriver::Error::ElementNotInteractableError: element not interactable

Drop CSP check on JS requests

7a02f66

Capybara::NotSupportedByDriverError: Capybara::Driver::Base#response_headers shouldn't redirect if invalid CSP target?

Add changelog

87a1b70

changelog: Upcoming Features, Identity Verification, Add personal key step screen

Enable personal key steps everywhere but production

f0861aa

So that they're enabled in test

Fix enabled steps referenced as strings, not symbols

7300af9

Enable JS for proofing component feature spec

4dc619e

Update complete_proofing_steps to confirm personal key

e63feff

Refactor specs for personal key enabled by default in test env

0142a5c

Opt-in review feature spec

3dcb8d4

Opt-in strict reproof specs

9c57971

Update accessibility spec URL assertions

f4a8cea

Check current path in array

9e5b299

Expand PII accordion before asserting content

f8314e3

JS browser would not have visibility to content otherwise

Acknowledge personal key in new JS-enabled specs

84830f3

Reuse common helper for cross-feature compat

aec6c2b

Open personal key confirmation modal when JS enabled

6137c06

Escape value of xml_doc in SAML test view

8ce6cef

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

More JS

73a3bbb

Revert to personal key enabled in development only

9cee416

So that tests run against the in-production version, but we re-run personal key pages with both side of the toggle

Use click_idv_continue for phone step progression

15cfc45

Because it's a spinner button, we need to be able to wait for navigation to complete

aduth force-pushed the aduth-lg-6193-wire-it-up branch from 00ff8cc to 15cfc45 Compare May 6, 2022 16:00

aduth merged commit c05f26a into main May 6, 2022

aduth deleted the aduth-lg-6193-wire-it-up branch May 6, 2022 18:27

This was referenced May 11, 2022

Update knapsack_rspec_report.json #6332

Merged

Partial KMS session encryption #6315

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LG-6193: Enable personal key step in development environment#6229

LG-6193: Enable personal key step in development environment#6229
aduth merged 48 commits intomainfrom
aduth-lg-6193-wire-it-up

aduth commented Apr 20, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

aduth Apr 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

aduth commented Apr 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aduth Apr 28, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aduth commented Apr 20, 2022 •

edited

Loading