Override default_url_options to set correct host, port in JS specs#6295
Merged
Override default_url_options to set correct host, port in JS specs#6295
Conversation
Since it's used for generating URLs
changelog: Internal, Automated Testing, Fix URL helpers for feature specs
mitchellhenke
approved these changes
May 3, 2022
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
…6295) * Stub real IdentityConfig.store.domain_name in specs Since it's used for generating URLs * Override default_url_options to set correct host, port in JS specs * Add changelog changelog: Internal, Automated Testing, Fix URL helpers for feature specs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #6229
Why: So that URL helpers use the correct, expected host name for the running server, rather than "example.com".
Reference: rspec/rspec-rails#1275
I had originally planned to leave this in #6229, but coincidentally, @SammySteiner had run into the same issue for specs for #6278.