LG-6160: Validate personal key value as case-insensitive, Crockford base32

[aduth]

Extracted from #6229

Why: So that a user is not prevented from submitting the personal key confirmation step due to case sensitivity, for feature parity with the existing screen.

[zachmargolis]

LGTM

[nprimak]

Would it make sense to have a second test where the values.toLowercase() match and we expect not to see an error?

[aduth]

Could you share a snippet of the test case you have in mind?

The idea with mixed case here and in the expectedValue above is to try to cover both upper- and lower- variations in either the expected value or the given value.

[zachmargolis]

oh one more thought! the keys are base32-crockford encoded, so that they fold 0 and o together, 1 and i, when we compare on the server we normalize them. We should probably do the same thing here while we're fixing

[zachmargolis]

link to source:

identity-idp/app/services/personal_key_generator.rb

Lines 17 to 38 in db4c94a

	def verify(plaintext_code)
	user.valid_personal_key?(normalize(plaintext_code))
	end
	def normalize(plaintext_code)
	normed = plaintext_code.gsub(/\W/, '')
	split_length = RandomPhrase::WORD_LENGTH
	normed_length = normed.length
	return INVALID_CODE unless normed_length == personal_key_length * split_length
	encode_code(code: normed, length: normed_length, split: split_length)
	rescue ArgumentError, RegexpError
	INVALID_CODE
	end
	private
	attr_reader :user
	def encode_code(code:, length:, split:)
	decoded = Base32::Crockford.decode(code)
	Base32::Crockford.encode(decoded, length: length, split: split).tr('-', ' ')
	end

[aduth]

Good call @zachmargolis , I'll add that. I guess we don't have any feature specs covering that? (That's what originally prompted me to create this pull request)

I also forgot we had created a package for that purpose. Ideally we could fold that in here, but since we still have to maintain the old page, we might have to keep it around for a while in its current form.

[zachmargolis]

I guess we don't have any feature specs covering that?

I'm not seeing any feature specs... but we do have unit test coverage of it:

identity-idp/spec/services/personal_key_generator_spec.rb

Lines 76 to 78 in db4c94a

	it 'forgives user mistaking O for 0' do
	expect(generator.verify(personal_key.tr('0', 'o'))).to eq true
	end

[aduth]

Enhanced feature spec coverage in d4599a5. Will implement it here shortly.

[aduth]

Implemented in a6404d6. I could have pulled in the library we used in @18f/identity-personal-key-input, but it kinda seemed a bit overkill?

[zachmargolis]

yeah it's silly to have a whole library that we can replicate with two regexes, this seems easy enough to maintain 👍