Update FormStepsButton to place choice of "Submit" or "Continue" to renderer#6280
Merged
Update FormStepsButton to place choice of "Submit" or "Continue" to renderer#6280
Conversation
anniehirshman-gsa
approved these changes
May 2, 2022
Contributor
anniehirshman-gsa
left a comment
anniehirshman-gsa
left a comment
There was a problem hiding this comment.
Sounds good to me, thanks! 👍
…enderer **Why**: Because the current implementation relies on the assumption that we would only ever want to show "Submit" as the label of the last button in the flow, which is not the intention, and is not compatible with the current implementation of the personal key confirmation modal in the IdV API React implementation. Related discussion: #6229 (comment) changelog: Upcoming Features, Identity Verification, Add personal key step screen
aduth
force-pushed
the
aduth-form-steps-button
branch
from
57a2ea2 to
0b1dc16
Compare
peggles2
pushed a commit
that referenced
this pull request
May 3, 2022
…enderer (#6280) * Update FormStepsButton to place choice of "Submit" or "Continue" to renderer **Why**: Because the current implementation relies on the assumption that we would only ever want to show "Submit" as the label of the last button in the flow, which is not the intention, and is not compatible with the current implementation of the personal key confirmation modal in the IdV API React implementation. Related discussion: #6229 (comment) changelog: Upcoming Features, Identity Verification, Add personal key step screen * Fix spec lingering reference to personal key confirm "Submit"
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
…enderer (#6280) * Update FormStepsButton to place choice of "Submit" or "Continue" to renderer **Why**: Because the current implementation relies on the assumption that we would only ever want to show "Submit" as the label of the last button in the flow, which is not the intention, and is not compatible with the current implementation of the personal key confirmation modal in the IdV API React implementation. Related discussion: #6229 (comment) changelog: Upcoming Features, Identity Verification, Add personal key step screen * Fix spec lingering reference to personal key confirm "Submit"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Because the current implementation relies on the assumption that we would only ever want to show "Submit" as the label of the last button in the flow, which is not the intention, and is not compatible with the current implementation of the personal key confirmation modal in the IdV API React implementation.
For the most part, these button labels are static. The one "gotcha" case is that "Documents" step in document capture should show "Continue" when a selfie is to be captured, and "Submit" otherwise. This was already checked for in existing test cases, for regression prevention.
Related discussion: #6229 (comment)