Fix SAML auth context handling for IAL2 strict request#6253
Conversation
For example, you can see the issue by checking out the changes of #6255 against the current |
|
I discovered an additional, similar issue with how we're not upgrading IAL1 accounts to IAL2 for IAL2 strict requests, but I filed this as a separate bug, since the changes here are sufficient to unblock me in #6229. See: LG-6217 |
|
@solipet , I pushed a minor revision in 3cd0288 to revert the IAL2 authns' constant to its original value, and instead check explicitly for IAL2 strict when considering requested attributes. While I sorta like the idea of disambiguating "IAL2" and "IAL2 strict", we don't have a tendency of doing that anywhere else, so this feels more in line with what we're usually doing when checking for IAL2 or IAL2 strict. Could you give it a quick look and let me know if this makes sense to you? |
12ad4c7 to
3cd0288
Compare
**Why**: So that an IAL2 strict request behaves similar to a standard IAL2 request, particularly in how a user should be directed to enter their password to decrypt PII if encrypted. [skip changelog]
Avoid disambiguating IAL2 as meaning either "IAL2" or "IAL2 strict", since we don't seem to have a tendency to do that
3cd0288 to
42fa86f
Compare
solipet
left a comment
There was a problem hiding this comment.
I agree with your decision to avoid messing with the current definition of IAL2 authn contexts.
* Fix SAML auth context handling for IAL2 strict request **Why**: So that an IAL2 strict request behaves similar to a standard IAL2 request, particularly in how a user should be directed to enter their password to decrypt PII if encrypted. [skip changelog] * Check explicitly for ial2_strict in SAML requested_attributes Avoid disambiguating IAL2 as meaning either "IAL2" or "IAL2 strict", since we don't seem to have a tendency to do that
Why: So that an IAL2 strict request behaves similar to a standard IAL2 request, particularly in how a user should be directed to enter their password to decrypt PII if encrypted.
Discovered in #6229, via failing feature specs where user would not be prompted to enter their password to decrypt profile when authenticating as IAL2 strict.