Use stubbed profile for authorization_count_spec#6255
Merged
Conversation
aduth
force-pushed
the
aduth-saml-auth-ial2-strict
branch
2 times, most recently
from
3cd0288 to
42fa86f
Compare
aduth
force-pushed
the
aduth-auth-count-spec-stubbed-profile
branch
from
8ed984f to
1cd4f79
Compare
**Why:** - For improved compatibility with JS-enabled proofing, where authorization counts rely on an "Agree and continue" redirect back to the SP. With the JavaScript browser, there is no server to redirect to, resulting in an error. - Improved performance, since proofing involves many steps - To limit the concern of the specs to authorization counts, not to the ability to successfully proof changelog: Internal, Automated Testing, Improve performance of automated tests
too many tests assume it won't be there (probably a problem worth resolving)
aduth
force-pushed
the
aduth-auth-count-spec-stubbed-profile
branch
from
1cd4f79 to
9782f48
Compare
As of #6262, we now check component as "blank?". In the real world, the value would be the vendor name, so add a placeholder value for tests.
shouldn't have been here - bad cherry-pick?
zachmargolis
reviewed
May 3, 2022
See: https://github.com/18F/identity-idp/pull/6255/files#r863108404 Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
* Use stubbed profile for authorization_count_spec **Why:** - For improved compatibility with JS-enabled proofing, where authorization counts rely on an "Agree and continue" redirect back to the SP. With the JavaScript browser, there is no server to redirect to, resulting in an error. - Improved performance, since proofing involves many steps - To limit the concern of the specs to authorization counts, not to the ability to successfully proof changelog: Internal, Automated Testing, Improve performance of automated tests * Only set PII for verified profile mocks * Require PII opt-in for profile stubs too many tests assume it won't be there (probably a problem worth resolving) * Add non-empty vendor for liveness check component As of #6262, we now check component as "blank?". In the real world, the value would be the vendor name, so add a placeholder value for tests. * Update authorization_count_spec.rb * Remove default PII shouldn't have been here - bad cherry-pick? * Avoid concat for user profile creation See: https://github.com/18F/identity-idp/pull/6255/files#r863108404 Co-Authored-By: Zach Margolis <zbmargolis@gmail.com> * Remove unnecessary user save Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zbmargolis@gmail.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by: #6253Extracted from #6229
Why: