LG-6193: Integrate IdV app personal key step into proofing flow (feature-flagged)#6269
Merged
LG-6193: Integrate IdV app personal key step into proofing flow (feature-flagged)#6269
Conversation
**Why**: So that a user can functionally complete the proofing process using the new IdV app. changelog: Upcoming Features, Identity Verification, Add personal key step screen
deal with it later
Maybe bug with testing-library? Seems to struggle querying by role "TypeError: style.getPropertyValue is not a function"
copied from personal_key_controller_spec.rb
jmhooper
approved these changes
Apr 28, 2022
peggles2
pushed a commit
that referenced
this pull request
May 3, 2022
…ure-flagged) (#6269) * LG-6193: Integrate IdV app personal key step into proofing flow **Why**: So that a user can functionally complete the proofing process using the new IdV app. changelog: Upcoming Features, Identity Verification, Add personal key step screen * Move completion behavior to pack * Add spec for VerifyFlow * Revert feature specs covering personal key page deal with it later * Fix VerifyFlow spec Maybe bug with testing-library? Seems to struggle querying by role "TypeError: style.getPropertyValue is not a function" * Stub applicant for VerifyController spec copied from personal_key_controller_spec.rb
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
…ure-flagged) (#6269) * LG-6193: Integrate IdV app personal key step into proofing flow **Why**: So that a user can functionally complete the proofing process using the new IdV app. changelog: Upcoming Features, Identity Verification, Add personal key step screen * Move completion behavior to pack * Add spec for VerifyFlow * Revert feature specs covering personal key page deal with it later * Fix VerifyFlow spec Maybe bug with testing-library? Seems to struggle querying by role "TypeError: style.getPropertyValue is not a function" * Stub applicant for VerifyController spec copied from personal_key_controller_spec.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from: #6229
This is basically the same as #6229, with the exception that the feature flag is not yet enabled. This means that you can reach the step only when changing the feature flag yourself, then navigating through the proofing flow.
The reason to separate this from #6229 is that the changes in #6229 became inflated to include both (a) the integration of the step and (b) numerous fixes to support proofing with JavaScript enabled for the feature specs.
Testing Instructions:
idv_api_enabled: truein your localconfig/application.ymlNext Steps:
Merging this separate from #6229 would allow rebasing to change the focus of #6229 to improving spec compatibility for JavaScript-enabled proofing.