Conversation
…proofing We may need to make a change in the future to require strict IAL2 users to proof with phone. This commit does some work towards making that possible. It makes changes to the authorization controller to prevent a user from being redirected at strict IAL2 unless they have proofed with phone. This change is not totally complete, there are changes that will need to go in place to remove the option during proofing. changelog: Upcoming feature, Proofing, A user will need to proof with a phone before being sent back to the IdP for strict IAL2 proofing
jmhooper
added
needs code review
status - work in progress
and removed
needs code review
labels
aduth
reviewed
Apr 28, 2022
| identity_needs_strict_ial2_verification? | ||
| end | ||
|
|
||
| def identity_needs_strict_ial2_verification? |
Contributor
There was a problem hiding this comment.
As I've recently discovered (LG-6217), we're already not very consistent, but: Should we have equivalent logic for SAML as well?
Contributor
Author
There was a problem hiding this comment.
Yes, however we don't support strict IAL2 in SAML today. I was going to figure out what it all looks like before moving it over
Contributor
Contributor
Author
There was a problem hiding this comment.
Interesting, I did not think SAML supported it at all. You may have jumped ahead of me a bit. Fortunately IAL2 strict is disabled in all the places that matter.
jmhooper
commented
Apr 28, 2022
| proofing_components['address_check'] == 'lexis_nexis_address' | ||
| end | ||
|
|
||
| def strict_ial2_proofed? |
Contributor
Author
There was a problem hiding this comment.
I would like to get includes_liveness_check? and includes_phone_check? out of the public API for the model eventually. First need to chase down all of the existing uses of includes_liveness_check?
peggles2
pushed a commit
that referenced
this pull request
May 3, 2022
…proofing (#6270) We may need to make a change in the future to require strict IAL2 users to proof with phone. This commit does some work towards making that possible. It makes changes to the authorization controller to prevent a user from being redirected at strict IAL2 unless they have proofed with phone. This change is not totally complete, there are changes that will need to go in place to remove the option during proofing. changelog: Upcoming feature, Proofing, A user will need to proof with a phone before being sent back to the IdP for strict IAL2 proofing
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
…proofing (#6270) We may need to make a change in the future to require strict IAL2 users to proof with phone. This commit does some work towards making that possible. It makes changes to the authorization controller to prevent a user from being redirected at strict IAL2 unless they have proofed with phone. This change is not totally complete, there are changes that will need to go in place to remove the option during proofing. changelog: Upcoming feature, Proofing, A user will need to proof with a phone before being sent back to the IdP for strict IAL2 proofing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We may need to make a change in the future to require strict IAL2 users to proof with phone. This commit does some work towards making that possible. It makes changes to the authorization controller to prevent a user from being redirected at strict IAL2 unless they have proofed with phone. This change is flagged off at the moment.
This change is not totally complete, there are changes that will need to go in place to remove the option during proofing.