Deploy stages/rc-2017-09-04-patch-1 to prod#1658
Merged
zachmargolis merged 95 commits intostages/prodfrom Sep 5, 2017
Merged
Conversation
**Why**: It's a best practice to define the host for assets and URLs, just like we do for mailers.
Set default URL options
**Why**: To provide a smooth experience when trying to log out. The spec states that: > Previously issued ID Token passed to the logout endpoint > as a hint about the End-User's current authenticated session > with the Client. which we can interpret as "allows expired tokens" as well.
**Why**: Consistent code is happy code.
Update gems with bummr
Update OIDC Logout to work with expired id_tokens
**Why**: We want to be able to test that code to limit the number of idv attempts works for both the OIDC and SAML flows. Note that the specs that require Javascript are included in a new feature spec file, since the code to send a request from a SP does not work with JS enabled.
Move tests for max idv attempts to shared example
**Why**: To pick up the Rails 5 deprecation fix for the use of `render nothing: true`.
Remove redundant PII warning
Fix leftover deprecation warnings in spec
Update saml_idp from 0.4.1-18f to 0.4.2-18f
Re-add mailcatcher to Procfile
**Why**: So that users can't use an expired mail OTP to verify an identity.
Add validation error when mail OTP is expired
**Why**: The spec appeared to have intermittent failures when clicking the "Try a different phone" link. It looks like the spec was checking the current path before the page had finished loading. This commit changes the spec so it looks for the phone input before checking the current path. The phone input line will wait for the phone input to appear meaning the page will have to have loaded and the current_path value will be correct.
…spec Fix flickering IdV flow spec
**Why**: Provide feedback (usually for developers)
**Why**: The gem hasn't been maintained in over a year, and we were only using a small portion of it (limiting session concurrency), which I've extracted into an initializer. The gem was preventing us from upgrading to Rails 5.1 due to the use of a deprecated method in part of the code we weren't even using.
Use NPM style guide package
Add an error page for bad SAML requests
Remove dependency on devise_security_extension
**Why**: To pick up a change that allows the IdP app to be updated to Rails 5.1
**Why**: To have the latest and greatest **How**: - Per the Rails docs, we have to create ApplicationRecord in models, then make all of our models inherit from it. - Per the Rails docs, we have to create ApplicationJob in jobs, then make all of our jobs inherit from it. - Rename `email_changed?` to `will_save_change_to_email?` and `email_was` to `email_in_database` since the ActiveModel::Dirty API has changed. - Remove redundant CORS OPTIONS test
Update redis session store and Rails to latest versions
**Why**: To fix rendering in browsers
Fix <title> tag double HTML escaping
Import stylesheets from style-guide
**Why**: To stop using before_action method in controllers
Upgrade saml_idp gem
**Why**: Error in production due to "request.protocol" being nil, using the asset_url helper in the view should provide access to the request
jmhooper
approved these changes
Sep 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RC 38