Skip to content

Use NPM style guide package#1619

Merged
hursey013 merged 1 commit intomasterfrom
bh-style-guide-again
Aug 17, 2017
Merged

Use NPM style guide package#1619
hursey013 merged 1 commit intomasterfrom
bh-style-guide-again

Conversation

@hursey013
Copy link
Contributor

The change needed to make this function when the app is deployed to the various envs has been added, so resubmitting this reverted PR.

Here is the previous PR for reference:

This uses the identity-style-guide NPM package to import shared assets. This first PR imports relatively low risk assets: font files, and favicons. A follow up PR will address shared stylesheets, images, and possibly some Javascript.

@hursey013 hursey013 self-assigned this Aug 16, 2017
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hursey013 hursey013 requested a review from mugizico August 17, 2017 12:50
@hursey013 hursey013 merged commit 6710747 into master Aug 17, 2017
@hursey013 hursey013 deleted the bh-style-guide-again branch August 17, 2017 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants