Skip to content

Import stylesheets from style-guide#1622

Merged
hursey013 merged 1 commit intomasterfrom
bh-remove-styles
Aug 18, 2017
Merged

Import stylesheets from style-guide#1622
hursey013 merged 1 commit intomasterfrom
bh-remove-styles

Conversation

@hursey013
Copy link
Contributor

@hursey013 hursey013 commented Aug 17, 2017

This removes the majority of the app's stylesheets, instead importing them from a shared style guide npm package.

I'm using a github branch for the identity-style-guide npm package for testing, but once it all looks good I can bump the version of the package and update this PR to reflect.

Copy link
Contributor

@nickbristow nickbristow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a code perspective, it seems fine to me.

@nickbristow
Copy link
Contributor

I'm getting an error trying to run this locally, but i think its unrelated

~/Projects/18f/identity-idp (bh-remove-styles) $ sudo npm install
npm ERR! code 1
npm ERR! Command failed: /usr/local/bin/git clone --depth=1 -q -b bh-add-app-styles git://github.com/18f/identity-style-guide.git /Users/richardbristow/.npm/_cacache/tmp/git-clone-7ddc295b
npm ERR! /Users/richardbristow/.npm/_cacache/tmp/git-clone-7ddc295b/.git: Permission denied
npm ERR! 

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/richardbristow/.npm/_logs/2017-08-17T20_52_01_972Z-debug.log

@hursey013 hursey013 requested a review from zachmargolis August 17, 2017 21:24
Copy link
Contributor

@gemfarmer gemfarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a redo of the other commit right? LGTM now that the chef build will run the right npm commands

@hursey013
Copy link
Contributor Author

@zachmargolis the previous PR just imported fonts & favicons - this extends that to now also include stylesheets.

@zachmargolis
Copy link
Contributor

@hursey013 got it, thanks for explaining! Still LGTM!

@hursey013 hursey013 merged commit 38e0c1d into master Aug 18, 2017
@hursey013 hursey013 deleted the bh-remove-styles branch August 18, 2017 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants