Conversation
nickbristow
approved these changes
Aug 17, 2017
Contributor
nickbristow
left a comment
There was a problem hiding this comment.
From a code perspective, it seems fine to me.
Contributor
|
I'm getting an error trying to run this locally, but i think its unrelated |
zachmargolis
approved these changes
Aug 17, 2017
Contributor
zachmargolis
left a comment
There was a problem hiding this comment.
This is just a redo of the other commit right? LGTM now that the chef build will run the right npm commands
Contributor
Author
|
@zachmargolis the previous PR just imported fonts & favicons - this extends that to now also include stylesheets. |
Contributor
|
@hursey013 got it, thanks for explaining! Still LGTM! |
613191f to
21e0094
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the majority of the app's stylesheets, instead importing them from a shared style guide npm package.
I'm using a github branch for the identity-style-guide npm package for testing, but once it all looks good I can bump the version of the package and update this PR to reflect.