Remove dependency on devise_security_extension#1621
Merged
Conversation
**Why**: The gem hasn't been maintained in over a year, and we were only using a small portion of it (limiting session concurrency), which I've extracted into an initializer. The gem was preventing us from upgrading to Rails 5.1 due to the use of a deprecated method in part of the code we weren't even using.
konklone
approved these changes
Aug 17, 2017
Contributor
konklone
left a comment
konklone
left a comment
There was a problem hiding this comment.
Seems good to me. For documentation purposes, would you mind adding a comment linking to the relevant tests that measure this change?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The gem hasn't been maintained in over a year, and
we were only using a small portion of it (limiting session concurrency),
which I've extracted into an initializer.
The gem was preventing us from upgrading to Rails 5.1 due to the
use of a deprecated method in part of the code we weren't even using.