Skip to content

Upgrade saml_idp gem#1627

Merged
zachmargolis merged 1 commit intomasterfrom
margolis-upgrade-saml-idp
Aug 21, 2017
Merged

Upgrade saml_idp gem#1627
zachmargolis merged 1 commit intomasterfrom
margolis-upgrade-saml-idp

Conversation

@zachmargolis
Copy link
Contributor

Why: To stop using before_action method in controllers

--

follow-up to 18F/saml_idp#8

**Why**: To stop using before_action method in controllers
@monfresh
Copy link
Contributor

Huh. Very strange. Not sure why it doesn't throw an exception when running the app locally or when running the tests.

Copy link
Contributor

@monfresh monfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachmargolis zachmargolis merged commit ac6684f into master Aug 21, 2017
@zachmargolis zachmargolis deleted the margolis-upgrade-saml-idp branch August 21, 2017 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants