Merged
Conversation
**Why**: The spec appeared to have intermittent failures when clicking the "Try a different phone" link. It looks like the spec was checking the current path before the page had finished loading. This commit changes the spec so it looks for the phone input before checking the current path. The phone input line will wait for the phone input to appear meaning the page will have to have loaded and the current_path value will be correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The spec appeared to have intermittent failures when clicking
the "Try a different phone" link. It looks like the spec was checking
the current path before the page had finished loading. This commit
changes the spec so it looks for the phone input before checking the
current path. The phone input line will wait for the phone input to
appear meaning the page will have to have loaded and the current_path
value will be correct.