Conversation
| nokogiri (~> 1.3) | ||
| zonebie (0.6.1) | ||
| zxcvbn-js (4.4.2) | ||
| zxcvbn-js (4.4.3) |
There was a problem hiding this comment.
should we bump the node package version to keep these in sync?
There was a problem hiding this comment.
Ah, yes. Good catch.
There was a problem hiding this comment.
Looks like it's not available yet?
No compatible version found: zxcvbn@^4.4.3
Should I revert the gem until the node package is available?
There was a problem hiding this comment.
Looks like the Ruby gem's versioning does not necessarily correspond to the Dropbox versioning. It looks like he made a change to the Ruby code and updated the version number, so I think we're good to go here.
https://github.com/bitzesty/zxcvbn-js/commits/master
There was a problem hiding this comment.
Yeah as long as it's still compatible with our patch to swap out the underlying JS, it's probably fine
👍
|
Thanks. Can you formally approve the PR please? |
|
Never mind. I see it now. |
2 participants
No description provided.