Update redis session store and Rails to latest versions#1625
Merged
Update redis session store and Rails to latest versions#1625
Conversation
**Why**: To pick up a change that allows the IdP app to be updated to Rails 5.1
**Why**: To have the latest and greatest **How**: - Per the Rails docs, we have to create ApplicationRecord in models, then make all of our models inherit from it. - Per the Rails docs, we have to create ApplicationJob in jobs, then make all of our jobs inherit from it. - Rename `email_changed?` to `will_save_change_to_email?` and `email_was` to `email_in_database` since the ActiveModel::Dirty API has changed. - Remove redundant CORS OPTIONS test
monfresh
force-pushed
the
mb-update-redis-session-store
branch
from
ddd82b4 to
591517a
Compare
|
|
||
| describe '#options' do | ||
| it 'is empty so it can be used as a pre-flight request' do | ||
| process :options, 'OPTIONS' |
Contributor
There was a problem hiding this comment.
does 5.1 no longer support sending OPTIONS requests? I really like having this spec because it makes sure we handle the OPTIONS which is important for CORS
Contributor
Author
There was a problem hiding this comment.
We have that spec already here: https://github.com/18F/identity-idp/blob/master/spec/requests/openid_connect_cors_spec.rb#L39-L54
I added an expectation for the empty body to that test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the commit message for the Rails upgrade for more details.