Deploy RC 424 to Production#11378
Merged
mitchellhenke merged 27 commits intostages/prodfrom Oct 22, 2024
Merged
Conversation
…ts (#11294) We use Threatmetrix for device profiling. When a user's device profiling transaction represents a review or reject status they need to undergo the fraud review process. Part of that process is looking at what was returned by Threatmetrix in the logged response body. The Threatmetrix response body is incredibly large. It causes some issues with Cloudwatch parsing the JSON written to the log. In 2ddece0 we started logging the response body on its own event. We continued to log the Threatmetrix response body in its original place on the verify info proofing results event. This was done so we can validate that the response body is properly logged on the new event and works for our purposes. This commit follows up that previous commit by removing the response body from the original event. We can merge this once we have verified that everything is working as expected with the new event. [skip changelog]
changelog: Internal, Automated Testing, Restructure PIV/CAC setup spec for consistency
changelog: Internal, Dependencies, Update dependencies to resolve security advisories
* Remove spacing in zh.yml * Add changelog changelog: User-Facing Improvements, Content, Improve text spacing for some content in Simplified Chinese
changelog: Internal, Identity Proofing, Log state_id_type on doc auth verify proofing results event
* changelog: Internal, split doc auth, remove past code and refrences to single page doc auth and split conditionals * Updating test, changing application yml to pass unused key check in identity_config_spec * Removing ununsed translation keys to resolve failing i18n_spec.rb, also removing outdated refrences in spec tests * Removing outdated variable, resolving PR comment * Resolving PR comments by remvoing parent contexts * Removing split doc auth contexts from hybrid handoff and redo doc capture specs * Breaking up shared example and combining before blocks for hybrid mobile spec * Changed name of context, resolving PR comment
* changelog: Internal, event tracking, remove out dated doc auth event tracker * Removing tests that check for outdated logs * Removing unneeded stub_analytics from before block of entry controller spec
changelog: Internal, Code Quality, Remove unused view code
…o socure_docv_transaction_token (#11360) * rename docv_token to docv_transaction_token [skip changelog] * switch to rename_column instead of add/remove column * this is a safe change since this column is not used in our deployed envs * fix tests to use new column
* hardcode hover states that arent the same as default * removed darkest custom utility * Add changelog changelog: Bux Fixes, Login Button Component, update hover state
* feat: move link texts on barcode page * feat: add translations * feat: remove class and use utility styling classes * changelog: User-Facing Improvements, In-person proofing, update signout link text * feat: remove unused content keys * feat: add event handler component * feat: update specs * feat: update french translations * feat: move link above cancel link * feat: fix the spacing * feat: reduce padding for accessibility violation * feat: more padding to fix tap target sizing
changelog: Upcoming Features, reCAPTCHA, Enable reCAPTCHA in log-only mode Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
When Socure responds to requests against its identity verification APIs it includes "reason codes" to describe why a transaction may have failed. These reason codes map back to descriptions that are available in the Reason Code API. Socure has suggested to us that we maintain our own copy of their reason codes. This commit adds a background job that will create/update a copy of the Socure reason codes and descriptions in our database on a weekly basis. The job fetches the list of codes from the API. It adds any new codes that do not exist in the database. It deactivates any codes that we have in the database that we do not observe in the response. The job will log the results when it is done. This includes: 1. A list of reason codes that were added 2. A list of reason codes that were deleted 3. Any exceptions that may have occurred when adding the codes. This change includes a `idv_socure_reason_code_download_enabled` config that controls whether this feature is active. It defaults to `false` since we are not currently utilizing Socure in production. changelog: Internal, Socure, Download and store reason codes weekly
* placeholder 2 * remove compose-components changelog: Internal, Maintenance, Remove compose-components JavaScript package
* Update good_job in preparation for 4.0 upgrade changelog: Internal, Maintenance, Update good_job in preparation for 4.0 upgrade * periodically check for v4 readiness
…ailed, and in_person_failed_fraud emails (#11353) * Refactor VerificationResultsEmailPresenter to distinguish between selected and visited location * Update in_person_failed_fraud, in_person_failed, and in_person_verified email templates to display visited location * Remove extraneous variables from in_person_deadline_passed email template * Refactor UserMailer, UserMailerSpec, and UserMailerPreview to distinguish between selected and visited location * Changelog: User-Facing Improvements, In-person Proofing, fix ipp emails to distinguish between selected and visited location name * Refactor GetUspsProofingResultsJob and its spec to distinguish between selected and visited location * refactor email methods to use keyword args * refactor args for please call email * remove selected_location_name from VerificationResultsEmailPresenter * fix failing spec for please call email
…onal env vars to review-apps (#11372)
…1365) changelog: Internal, Configuration, Add test to require all config defined in application.yml.default
* Extract common spec helpers for decoding OIDC tokens changelog: Internal, Automated Testing, Extract common spec helpers for decoding OIDC tokens * Fix intermittent issue with checking checkbox * Use Faraday for interacting with OIDC API Avoid affecting page global * Handle redirect URI for JavaScript * Fix variable reference for token responses * Revert to using driver for network request WebMock disables real network requests in non-JS specs
* Update rspec-rails to lint deprecated enum keywords changelog: Internal, Linting, Update rspec-rails to lint deprecated enum keywords * Fix Socure reason code deactivate lint
…rification to discouraged (#11354)
* Remove check_sp_required_mfa_bypass * Update specs to assert user flow enforces phishing-resistant * Add changelog changelog: Internal, Code Quality, Consolidate phishing-resistant MFA checks to protocol controllers
changelog: Internal, Logging, Add cpu_time and idle_time to job logs
Added helpful text before the selfie-capture screen. changelog: User-Facing Improvements, Split document capture,Added helpful explanation to the selfie page.
aduth
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features