Skip to content

Add test to require all config defined in application.yml.default#11365

Merged
aduth merged 1 commit intomainfrom
aduth-test-defaults-application-yaml
Oct 22, 2024
Merged

Add test to require all config defined in application.yml.default#11365
aduth merged 1 commit intomainfrom
aduth-test-defaults-application-yaml

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Oct 18, 2024

🛠 Summary of changes

Adds a test that requires all configuration to have a default value specified in the top-level of application.yml.default.

Why?

  • So it's clearer by looking at application.yml.default all of the available configuration
    • Adds missing values:
      • lexisnexis_threatmetrix_api_key
      • lexisnexis_threatmetrix_base_url
      • lexisnexis_threatmetrix_org_id
      • lexisnexis_threatmetrix_policy
  • It complements the existing "redundant configuration" by ensuring a value exists in the default scope, particularly where previously two environments may have shared the same configuration, now collapsed to a single default value in the top-level scope

Previous discussion: #11340 (comment)

📜 Testing Plan

rspec spec/lib/identity_config_spec.rb

Review that there's no effective changes in configuration in config/application.yml.default.

changelog: Internal, Configuration, Add test to require all config defined in application.yml.default
@aduth aduth force-pushed the aduth-test-defaults-application-yaml branch from ae03c15 to e792017 Compare October 22, 2024 11:49
@aduth aduth merged commit bba7cc4 into main Oct 22, 2024
@aduth aduth deleted the aduth-test-defaults-application-yaml branch October 22, 2024 12:13
MrNagoo pushed a commit that referenced this pull request Oct 25, 2024
…1365)

changelog: Internal, Configuration, Add test to require all config defined in application.yml.default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants