Skip to content

Remove some spacing in zh.yml #11356

Merged
nickttng merged 2 commits intomainfrom
2024-10-16-ZH-Lang-Spacing
Oct 17, 2024
Merged

Remove some spacing in zh.yml #11356
nickttng merged 2 commits intomainfrom
2024-10-16-ZH-Lang-Spacing

Conversation

@nickttng
Copy link
Contributor

In this PR, I'm requesting an engineer(s) to review.

🎫 Ticket

Link to the relevant ticket:
LG-14803

🛠 Summary of changes

As part of Chinese (Simplified) quality assurance check, I am deleting the extra spacing in several instances that DOS is requesting to remove.

SBAR details in the document.

📜 Testing Plan

Only extra spacing in certain instances are deleted.

No characters, symbols, or punctuation marks are deleted.

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickttng
Copy link
Contributor Author

@aduth Thanks for the review.

Question: How might I get this to pass one of the items in the GitLab stage?

@aduth
Copy link
Contributor

aduth commented Oct 17, 2024

You need to include a commit that includes a changelog in the expected format:

https://github.com/18F/identity-idp/blob/main/CONTRIBUTING.md#changelog-messages

Something like this should work:

git commit -m "Add changelog" -m "changelog: User-Facing Improvements, Content, Improve text spacing for some content in Simplified Chinese" --allow-empty
git push

changelog: User-Facing Improvements, Content, Improve text spacing for some content in Simplified Chinese
@nickttng nickttng merged commit 6116689 into main Oct 17, 2024
@nickttng nickttng deleted the 2024-10-16-ZH-Lang-Spacing branch October 17, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants