Add feature usage table to Protocols Report#11369
Merged
Conversation
zachmargolis
approved these changes
Oct 21, 2024
| ) | ||
| end | ||
|
|
||
| def protocols_report |
Contributor
There was a problem hiding this comment.
this is covered by a spec that automatically iterates over all the preview methods right?
Contributor
Author
There was a problem hiding this comment.
yes it is, i checked! it's here https://github.com/18F/identity-idp/blob/main/spec/mailers/previews/report_mailer_preview_spec.rb#L9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Add facial match query to protocols report](https://gitlab.login.gov/lg-people/Melba/backlog-fy24/-/issues/123)
🛠 Summary of changes
My first ticket related to these changes didn't include the new table in the emailable report method, so when the weekly email went out the feature usage table was not included.
This change:
localhost:3000/rails/mailersso it's easier to catch these kinds of issues.