changelog: Internal, Tests, Updating some tests to be easier to read#11352
Merged
changelog: Internal, Tests, Updating some tests to be easier to read#11352
Conversation
lmgeorge
approved these changes
Oct 16, 2024
Contributor
lmgeorge
left a comment
lmgeorge
left a comment
There was a problem hiding this comment.
LGTM! Really like how this makes the focus on what attributes are shown more clear.
Comment on lines
-88
to
-93
| before do | ||
| user.identities << identity | ||
| allow(service_provider.metadata).to receive(:[]).with(:attribute_bundle). | ||
| and_return(%w[email phone first_name]) | ||
| subject.build | ||
| end |
Contributor
There was a problem hiding this comment.
🥇 for getting rid of all this boilerplate setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
I was working on a change that required some tests added to this spec file, and I got fed up with how it is structured, so I updated it to use a factory object rather than a double. This allowed me to hydrate the service provider with the correct data, rather than having to rely on stubs. The change ended up being out of scope of the other change, so I pulled it into its own branch for ease of review.